Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Support use of Service Mesh for routing #1087

Closed
cam-garrison opened this issue Apr 4, 2023 · 2 comments · Fixed by #1088
Closed

[Feature Request]: Support use of Service Mesh for routing #1087

cam-garrison opened this issue Apr 4, 2023 · 2 comments · Fixed by #1088
Assignees
@cam-garrison
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/normal An issue with the product; fix when possible

Comments

@cam-garrison
Copy link

Feature description

In order to enable service mesh for routing between ODH components, we need to make some changes to ODH-Dashboard.

  • Create a feature flag to differentiate between when using service mesh as part of the ODH infrastructure and not.
  • If using service mesh, create requisite service mesh annotations when creating notebook and data science project resources.
  • If using service mesh, ensure that traffic goes through the mesh rather than openshift routes.

Describe alternatives you've considered

No response

Anything else?

PR incoming.
@cam-garrison cam-garrison added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet labels Apr 4, 2023
@cam-garrison cam-garrison mentioned this issue Apr 4, 2023
Merged
6 tasks
@Gkrumbach07 Gkrumbach07 added infrastructure Anything non feature/* related that improves general working of the Dashboard priority/normal An issue with the product; fix when possible and removed untriaged Indicates the newly create issue has not been triaged yet labels Apr 5, 2023
@Gkrumbach07
Copy link
Member

cc @lucferbux can you add a specific feature label for this

@bartoszmajsak bartoszmajsak mentioned this issue Sep 6, 2023
Open
@andrewballantyne andrewballantyne removed this from the Current Release milestone Sep 15, 2023
@lucferbux lucferbux added tracker Non-completable ticket; used for tracking work - akin to a Jira Epic and removed tracker Non-completable ticket; used for tracking work - akin to a Jira Epic labels Sep 21, 2023
@lucferbux lucferbux mentioned this issue Sep 21, 2023
Closed
@andrewballantyne
Copy link
Member

Merged into the feature branch -- getting it into incubation... see the Tracker for more details.

@andrewballantyne andrewballantyne added kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. and removed kind/enhancement New functionality request (existing augments or new additions) labels Oct 4, 2023
@andrewballantyne andrewballantyne mentioned this issue Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cam-garrison cam-garrison

Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/normal An issue with the product; fix when possible
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ossm): adds OSSM annotations to the relevant cluster resources maistra/odh-dashboard
4 participants
@andrewballantyne @Gkrumbach07 @lucferbux @cam-garrison