Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Create Model Server redirects to Data Science Project Screen #1091

Closed
1 task done
strangiato opened this issue Apr 7, 2023 · 11 comments · Fixed by #1796 or #1835
Closed
1 task done

[Bug]: Create Model Server redirects to Data Science Project Screen #1091

strangiato opened this issue Apr 7, 2023 · 11 comments · Fixed by #1796 or #1835
Assignees
Labels
feature/model-serving Model Serving Feature field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.35 rhods-2.4

Comments

@strangiato
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When navigating to the Model Serving tab if I currently don't have a model server created it includes a button to Create server.

image

When clicking that button, the page navigates to the Data Science Projects page with no additional context or information available:

image

There is no clear "next steps" a user needs to take or any feedback provided to the user as to what they need to do. It is not clear that you must either create a project and then from that page create a model server or select a project and then create a model server.

There is no indication that a Model Server is a project scoped object and no indication that I need to create one in my project before I can server a model.

Expected Behavior

Instead of redirecting the user to the Data Science Projects page, pop up a modal just like with the option to Deploy model.

Steps To Reproduce

See current behavior

Workaround (if any)

No response

What browsers are you seeing the problem on?

Chrome

Open Data Hub Version

1.5.0

Anything else

In all honestly the project / object scope workflow for the odh-dashboard makes very little sense to me.

Why can I create a Deploy model outside of the Data Science Project interface with a dropdown menu in the modal but I have to create the server under the Data Science Project menu?

image

If a Data Science Project is a namespace/project proxy in the ODH/RHODS interface, why not fall back on the same navigation language as the OpenShift console.

Provide a drop down menu to select which "project" you are in.

Allow the types of objects to be navigable items in the left panel:

  • Workbenches
  • Cluster Storage
  • Data Connections
  • Model Servers
  • Models

If you really want to combine some of those things like Model servers and models on a single page that would still work since these pages aren't likely to be dense.

Each of these pages should only display the objects belonging to that specific project to clearly show the scope of those objects.

@strangiato strangiato added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet labels Apr 7, 2023
@lucferbux lucferbux added priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) and removed untriaged Indicates the newly create issue has not been triaged yet labels Apr 10, 2023
@lucferbux
Copy link
Contributor

@vconzola @andrewballantyne

This flow is intended but maybe is misleading to the user, we might wanna review the description to make it more clear?

@vconzola
Copy link

@lucferbux Looking at my mockups I realize that I never addressed the scenario of what to show under Model Serving when no models are deployed. Rather than offering a Create model server action in this empty state, I think we should simply inform the user that no deployed models exist and re-direct them to the Projects page where they can create a model server and deploy a model. I'll mock something up to address this scenario. I think part of the confusion results from the nav item being called "Model serving" rather than "Deployed models", but that was edicted from on high.

@lucferbux
Copy link
Contributor

@lucferbux Looking at my mockups I realize that I never addressed the scenario of what to show under Model Serving when no models are deployed. Rather than offering a Create model server action in this empty state, I think we should simply inform the user that no deployed models exist and re-direct them to the Projects page where they can create a model server and deploy a model. I'll mock something up to address this scenario. I think part of the confusion results from the nav item being called "Model serving" rather than "Deployed models", but that was edicted from on high.

Great thanks!

@andrewballantyne andrewballantyne added this to the Upcoming Release milestone Apr 18, 2023
@andrewballantyne andrewballantyne added priority/normal An issue with the product; fix when possible and removed priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) labels Apr 18, 2023
@DaoDaoNoCode
Copy link
Member

@vconzola Just want to follow up, is there any update on this issue about the mockup?

@andrewballantyne andrewballantyne added the feature/model-serving Model Serving Feature label May 18, 2023
@vconzola
Copy link

@DaoDaoNoCode I think this is going to be addressed as part of bigger changes to Model serving to make it more consistent with Pipelines. Watch the recording of the 5/25 UX meeting to hear the details.

@andrewballantyne andrewballantyne added the field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality label Jun 22, 2023
@manaswinidas
Copy link
Contributor

I think this issue(or a part of it) is already addressed.
Screenshot 2023-06-28 at 11 54 39 PM

@vconzola
Copy link

vconzola commented Jun 28, 2023

@manaswinidas @DaoDaoNoCode Sorry. I created a mockup for this empty state and then never put a link in the issue. It should look like this: https://www.sketch.com/s/113593f8-5970-49d6-a352-709b07639127/a/uuid/00D5CBEB-9D5F-4886-BCB4-ECE815B2C991

@kaedward Please review the content for this empty state.

@lucferbux
Copy link
Contributor

@manaswinidas @DaoDaoNoCode Sorry. I created a mockup for this empty state and then never put a link in the issue. It should look like this: https://www.sketch.com/s/113593f8-5970-49d6-a352-709b07639127/a/uuid/00D5CBEB-9D5F-4886-BCB4-ECE815B2C991

@kaedward Please review the content for this empty state.

Ok, I'm gonna take this issue, I'm starting with it but I probably raise the pr next week.

@kaedward
Copy link

@vconzola I reviewed the empty state but didn't update here, whoops

@lucferbux lucferbux modified the milestones: Upcoming Release, Current Release Aug 9, 2023
@andrewballantyne andrewballantyne modified the milestones: Current Release, Upcoming Release Aug 16, 2023
@andrewballantyne andrewballantyne removed this from the Current Release milestone Sep 15, 2023
@andrewballantyne
Copy link
Member

andrewballantyne commented Sep 20, 2023

Accidental merge -- PR is being reverted and ticket is reopened for the work to be reviewed.

@lucferbux
Copy link
Contributor

@manaswinidas @DaoDaoNoCode Sorry. I created a mockup for this empty state and then never put a link in the issue. It should look like this: https://www.sketch.com/s/113593f8-5970-49d6-a352-709b07639127/a/uuid/00D5CBEB-9D5F-4886-BCB4-ECE815B2C991

@kaedward Please review the content for this empty state.

For future reference, here you have the right text: #1796 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.35 rhods-2.4
Projects
Status: Done
Archived in project
Status: Dashboard
9 participants