Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Technical]: useTableColumnSort needs to not be publicly used by components #1252

Closed
andrewballantyne opened this issue May 17, 2023 · 0 comments · Fixed by #1784
Closed
Assignees
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) rhods-1.34

Comments

@andrewballantyne
Copy link
Member

Feature description

We have a Table component now that bridges our interface with that of PF components.

However, we are still using useTableColumnSort outside of it. That should no longer be the case -- the table already sorts the data. We should fix this.

Remove all references to the table sort outside of the table components/hooks -- ideally we even take the type out of the hook file and place it in a types file so it can be more generically referenced.

Ideally I'd like to see an index file at the root of src/components/table that exposes items that are intended for consumption and excludes the useTableColumnSort hook proper from that file. This way it drives home more that you're digging into implementation you shouldn't be doing. We might get a linter for this in the long run.

Describe alternatives you've considered

No response

Anything else?

Related to #1250

@andrewballantyne andrewballantyne added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet labels May 17, 2023
@Gkrumbach07 Gkrumbach07 added infrastructure Anything non feature/* related that improves general working of the Dashboard priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) and removed untriaged Indicates the newly create issue has not been triaged yet labels May 25, 2023
@andrewballantyne andrewballantyne added kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc and removed kind/enhancement New functionality request (existing augments or new additions) labels May 29, 2023
@DaoDaoNoCode DaoDaoNoCode self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) rhods-1.34
Projects
Status: No status
Archived in project
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants