[Technical]: useTableColumnSort
needs to not be publicly used by components
#1252
Labels
infrastructure
Anything non feature/* related that improves general working of the Dashboard
kind/tech-debt
A technical debt item for the development team. E.g. Refactors / Tests / etc
priority/low
An issue with the product that doesn't impact the user much or not at all (ie tech debt)
rhods-1.34
Feature description
We have a Table component now that bridges our interface with that of PF components.
However, we are still using
useTableColumnSort
outside of it. That should no longer be the case -- the table already sorts the data. We should fix this.Remove all references to the table sort outside of the table components/hooks -- ideally we even take the type out of the hook file and place it in a types file so it can be more generically referenced.
Ideally I'd like to see an index file at the root of
src/components/table
that exposes items that are intended for consumption and excludes theuseTableColumnSort
hook proper from that file. This way it drives home more that you're digging into implementation you shouldn't be doing. We might get a linter for this in the long run.Describe alternatives you've considered
No response
Anything else?
Related to #1250
The text was updated successfully, but these errors were encountered: