Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accelerator table #1373

Closed
Gkrumbach07 opened this issue Jun 13, 2023 · 6 comments · Fixed by #2069
Closed

Add accelerator table #1373

Gkrumbach07 opened this issue Jun 13, 2023 · 6 comments · Fixed by #2069
Assignees
Labels
feature/accelerator-support All things related to Accelerators feature/adminui Admin UI Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Jun 13, 2023

Goal

Create a table to list available accelerator devices including the device indicator, display name, descriptions, enablement, and last modified date

Dependency issue

Itemized goals

  • Render the following columns: Device identifier, display name/description, ennoblement switch, date last modified, action button
  • Columns (except for action column) must be sortable
  • include help icons where present in the docs
  • should include pagination
  • ellipsis action button should include: edit, delete
  • hook to fetch accelerator CRDs
  • Display a label next to accelerator name for Nvidia GPU and HBU
  • alert to notify if migrated gpu was generated (press X to go away or on save of profile ??)

Aspects continued elsewhere

Mocks

https://www.sketch.com/s/d8550d2f-fae4-44fd-82df-9f400563d459/a/P1R0eVL

@Gkrumbach07 Gkrumbach07 added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Jun 13, 2023
@Gkrumbach07 Gkrumbach07 added this to the Habana milestone Jun 13, 2023
@Gkrumbach07 Gkrumbach07 added feature/adminui Admin UI Feature feature/accelerator-support All things related to Accelerators feature/habana Used for tracking among different projects for the Habana Feature labels Jun 13, 2023
@Gkrumbach07 Gkrumbach07 removed the feature/habana Used for tracking among different projects for the Habana Feature label Jun 13, 2023
@Gkrumbach07
Copy link
Member Author

UX Needed (not a blocking UX request)

@yannnz

the mocks still show that the accelerator table in the admin panel should have labels for Nvidia GPUs and HBUs. However i recall a conversation where we said that we dont want to hard code a relationships between accelerator and display label. What are your thoughts on this. Pic for ref

image

@yannnz
Copy link

yannnz commented Oct 16, 2023

@Gkrumbach07 Since we are planning to support toleration, it can be an opportunity to add the Group feature to allow the admin naming the labels as I proposed before: https://www.sketch.com/s/d8550d2f-fae4-44fd-82df-9f400563d459/a/L4bvgpy .
If the admin can customize group names, it will not require us to hard code the labels. Please refer the discussion here for the support of the toleration and group: https://sketch.com/s/d8550d2f-fae4-44fd-82df-9f400563d459/a/bLaM5Yo?annotation=25d20569-2f77-4bb7-9322-5acc393a5d26
cc: @andrewballantyne @xianli123 @kywalker-rh

@andrewballantyne
Copy link
Member

If the admin can customize group names, it will not require us to hard code the labels

There will be no hardcoding of anything in the UI now that we have Accelerator Profiles. Only hardcoded scenario is our migration script to move them into AcceleratorProfiles with Nvidia GPU.

As for "supporting versions of cards" -- I think we still need to figure out some stuff. See my req comment where I ask @Xaenalt what our options here are.

IMO though, groups in themselves can be part of this effort, we have the runway to do it right as we want it. I do imagine this is optional for the user though.

@yannnz
Copy link

yannnz commented Oct 19, 2023

@andrewballantyne @Gkrumbach07 Please help to review the design for Tolerations and Groups: https://www.sketch.com/s/d8550d2f-fae4-44fd-82df-9f400563d459/a/JAW7zxr

@dpanshug dpanshug self-assigned this Oct 30, 2023
@xianli123
Copy link

@dpanshug Here is the latest design of the Accelerator profiles table fyi.

@Gkrumbach07
Copy link
Member Author

@dpanshug dpanshug mentioned this issue Nov 6, 2023
13 tasks
@dgutride dgutride linked a pull request Nov 6, 2023 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accelerator-support All things related to Accelerators feature/adminui Admin UI Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants