Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Image Error has Misleading Enabled State #1388

Closed
1 task done
andrewballantyne opened this issue Jun 14, 2023 · 3 comments · Fixed by #1529
Closed
1 task done

[Bug]: Image Error has Misleading Enabled State #1388

andrewballantyne opened this issue Jun 14, 2023 · 3 comments · Fixed by #1529
Assignees
Labels
feature/byon Bring Your Own Notebook Feature field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality good first issue Good for newcomers priority/normal An issue with the product; fix when possible

Comments

@andrewballantyne
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When you put an registry & image path into the BYON custom images modal and it doesn't reference a valid tag it will eventually error out on the async nature of OpenShift validating the image.

We then show the error on the list page and hide the image from the selection in creating a Notebook. However, the admin view it still looks enabled and may cause confusion.

Expected Behavior

What we should do is, on render of the custom notebook table, we flip the toggle to disabled and then disable the toggle so they cannot re-enable it. The error should provide the context.

This will give a better impression that it is not "enabled" with the error.

Steps To Reproduce

  1. Be an admin
  2. Create a new custom notebook image with an invalid tag
  3. Wait for the error to appear

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Open Data Hub Version

Dashboard: v2.11.0

Anything else

No response

@andrewballantyne andrewballantyne added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet labels Jun 14, 2023
@lugi0
Copy link
Contributor

lugi0 commented Jun 15, 2023

Tracking downstream in: https://issues.redhat.com/browse/RHODS-9384

@lucferbux lucferbux added good first issue Good for newcomers priority/normal An issue with the product; fix when possible feature/byon Bring Your Own Notebook Feature and removed kind/bug Something isn't working labels Jun 19, 2023
@lucferbux lucferbux added this to the Current Release milestone Jun 19, 2023
@Gkrumbach07 Gkrumbach07 removed the untriaged Indicates the newly create issue has not been triaged yet label Jun 21, 2023
@andrewballantyne andrewballantyne removed this from the Current Release milestone Jul 6, 2023
@DaoDaoNoCode
Copy link
Member

This issue will be fixed with the refactoring of Custom Notebook Phase 1 #1254

@DaoDaoNoCode DaoDaoNoCode self-assigned this Jul 17, 2023
@DaoDaoNoCode DaoDaoNoCode linked a pull request Jul 17, 2023 that will close this issue
7 tasks
@lucferbux lucferbux added the field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality label Jul 19, 2023
@manosnoam
Copy link

Verified on RHODS 2.4:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/byon Bring Your Own Notebook Feature field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality good first issue Good for newcomers priority/normal An issue with the product; fix when possible
Projects
Archived in project
Status: Dashboard
Development

Successfully merging a pull request may close this issue.

6 participants