[Bug]: Custom serving runtimes can have arbitrarily long names

[lucferbux]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

When creating a custom runtime, users can give it an arbitrarily long display name. This can cause the "serving runtimes" section of the dashboard to break (i.e. buttons get pushed out of reach) if the name is long enough.

We need to address:

1. Truncate values when there are no spaces in the text

Expected Behavior

Table doesn't expand as large as the name.

Look at using PF Truncate

Steps To Reproduce

1. Go to serving runtimes page
2. Create a new serving runtime with a long display name

[lugi0]

This issue is still somewhat present in the Serving runtime dropdown in the Add model server modal.

The text does not wrap (nor is it truncated), and while it does not break the UI it is clear it is extending the name out of bounds of the modal.

I can get the text to wrap by removing the current class from the button element (pf-c-select__menu-item) and instead giving it the same class given to the table element in Serving runtimes (pf-u-text-break-word pf-m-width-70), but it loses the styling of the modal, and using both classes at the same time does not wrap the text, so this might not be a viable solution here.

Attaching a few screenshots for clarity

[lugi0]

Actually, the UI does break once a model server is deployed using the serving runtime with the long unbreakable word

[andrewballantyne]

Ah -- we didn't solve it all three spots:

1. [Solved] Settings => Custom Serving Runtimes
2. DS Projects => [project] => Models and model servers section
3. DS Projects => [project] => Create Server => select Runtime dropdown

Seems we need another issue to make sure it's covered in the other two spots. I'll log something in a moment.

[lucferbux]

Ah -- we didn't solve it all three spots:

1. [Solved] Settings => Custom Serving Runtimes
2. DS Projects => [project] => Models and model servers section
3. DS Projects => [project] => Create Server => select Runtime dropdown

Seems we need another issue to make sure it's covered in the other two spots. I'll log something in a moment.

woopsie, once. i reopened it your message has popped up in the timeline, I'm gonna close it again.