Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the enabled/disabled status after editing the custom notebook image #1434

Closed
DaoDaoNoCode opened this issue Jun 26, 2023 · 2 comments · Fixed by #1436
Closed

Keep the enabled/disabled status after editing the custom notebook image #1434

DaoDaoNoCode opened this issue Jun 26, 2023 · 2 comments · Fixed by #1436
Assignees
@uidoyen
Labels
feature/byon Bring Your Own Notebook Feature good first issue Good for newcomers kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Milestone
Custom Notebook (...

Comments

@DaoDaoNoCode
Copy link
Member

DaoDaoNoCode commented Jun 26, 2023 •
edited

Goal

Make sure the status doesn't change after editing the notebook image

Dependency issue

Tracker: #1254

Itemized goals

After editing an image, the 'enabled' state is automatically set to disable. Any edits should not change the state - if enabled prior to edits, it should remain enabled after edits and if disabled prior to edits, it should remain disabled after edits.

This is a bug and should be as simple as a one-line fix. Check here, the check is wrong, it should directly check the body.visible instead of typeof body.visible when updating the image stream.

Aspects continued elsewhere

No response

Mocks

No mocks
@DaoDaoNoCode DaoDaoNoCode added kind/bug Something isn't working good first issue Good for newcomers priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/byon Bring Your Own Notebook Feature labels Jun 26, 2023
@DaoDaoNoCode DaoDaoNoCode mentioned this issue Jun 26, 2023
Closed
@uidoyen
Copy link
Contributor

uidoyen commented Jun 27, 2023

/assign

@uidoyen uidoyen mentioned this issue Jun 27, 2023
Merged
6 tasks
@manosnoam
Copy link

Verified on RHODS 2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uidoyen uidoyen

Labels
feature/byon Bring Your Own Notebook Feature good first issue Good for newcomers kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
ODH Dashboard Planning
Archived in project
Milestone
Custom Notebook (BYON) Improvements -...
Development

Successfully merging a pull request may close this issue.

Keep the enabled/disabled status after editing the custom notebook image uidoyen/odh-dashboard
4 participants
@uidoyen @andrewballantyne @manosnoam @DaoDaoNoCode