Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker]: Support versions for pipelines #1575

Closed
andrewballantyne opened this issue Jul 25, 2023 · 14 comments
Closed

[Tracker]: Support versions for pipelines #1575

andrewballantyne opened this issue Jul 25, 2023 · 14 comments
Assignees
Labels
feature/ds-pipelines Data Science Pipelines feature (aka DSP) field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality migrated needs-microcopy Needs UX wording support tracker Non-completable ticket; used for tracking work - akin to a Jira Epic

Comments

@andrewballantyne
Copy link
Member

andrewballantyne commented Jul 25, 2023

Description

We don't currently show Pipeline Versions in the Dashboard UI, only the first default version associated to a Pipeline. We would like to show all versions and have the proper selection throughout to support them.

Target Branch

f/pipelines-enhancement

Requirements

P0: Ability to add new pipeline versions and access previous versions in the UI
Can do runs against previous versions

Itemized UX Issues

TBD

Itemized Dev Issues

Infrastructure:
Global pipelines page:
Pipeline details page:
Pipeline runs:
Components:
Other items:

Related artifacts

@andrewballantyne andrewballantyne added tracker Non-completable ticket; used for tracking work - akin to a Jira Epic feature/ds-pipelines Data Science Pipelines feature (aka DSP) labels Jul 25, 2023
@andrewballantyne
Copy link
Member Author

cc @yannnz @kywalker-rh

@andrewballantyne andrewballantyne added the field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality label Jul 25, 2023
@yannnz
Copy link

yannnz commented Aug 31, 2023

This is the latest design mockup: https://www.sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/a/lRzqa1x

There are still two things that we need to decide:

  1. Can the backend auto generates the pipeline version name with version number rather than following the KBF's long timestamp format? Waiting for Harshad to confirm.
  2. Do we want to provide filtering Runs/Jobs by Pipeline names?

cc: @andrewballantyne @uidoyen @kywalker-rh
cc: @kaedward Could you help to review the content? Thanks!

@andrewballantyne
Copy link
Member Author

@yannnz

(1) might be possible, but that shouldn't hold us up right? What design hinders on the answer to this question?

(2) Is not possible based on Humair's findings. My opinion is we just scratch that one out fully -- no filtering on Pipelines at all; only Pipeline Versions (which is very unfortunate for our UI).

@yannnz
Copy link

yannnz commented Sep 1, 2023

@yannnz

(1) might be possible, but that shouldn't hold us up right? What design hinders on the answer to this question?

(2) Is not possible based on Humair's findings. My opinion is we just scratch that one out fully -- no filtering on Pipelines at all; only Pipeline Versions (which is very unfortunate for our UI).

The first point won't hold us up. It will only need to display very long names in UI.
Agree with the second point.

@yannnz
Copy link

yannnz commented Sep 8, 2023

@andrewballantyne @uidoyen I got two questions when I was preparing the demo for Thursday's UX review meeting. It is specific for the Pipeline dropdown and Pipeline version dropdown. Will we have the same issue as what we have on table list to load pipeline options and version options all in once when the list is long? I think we will, so I added a solution for it. The demo only shows the dropdown for Create a run modal. But if this case effects all Pipeline/Pipeline version dropdowns, we can apply the same approach: https://www.sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/a/L495k0L

Demo recording (24min27s)
Question 1: 15:45
Question 2: 17:00

@yannnz
Copy link

yannnz commented Sep 29, 2023

The Pipeline & Pipeline version dropdown are updated. Please help to review the design :
Mockup of Pipeline & Pipeline version dropdown @andrewballantyne @kywalker-rh

@andrewballantyne andrewballantyne changed the title Support versions for pipelines [Tracker]: Support versions for pipelines Oct 11, 2023
@andrewballantyne
Copy link
Member Author

@yannnz are you completely done your first pass of Versions or are we still looking for more? I'm wondering if I should log you a UX issue to finalize the effort here or if the latest mocks (https://www.sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/p/52D4BC1C-F002-4775-9C69-7E82C519E931/canvas) are good to go? I'd like to break down the UI stories soon too.

cc @kywalker-rh @dgutride

@kaedward kaedward added the needs-microcopy Needs UX wording support label Oct 11, 2023
@yannnz
Copy link

yannnz commented Oct 12, 2023

@yannnz are you completely done your first pass of Versions or are we still looking for more? I'm wondering if I should log you a UX issue to finalize the effort here or if the latest mocks (https://www.sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/p/52D4BC1C-F002-4775-9C69-7E82C519E931/canvas) are good to go? I'd like to break down the UI stories soon too.

cc @kywalker-rh @dgutride

@andrewballantyne The latest mockups are good to go from my side.

@yannnz
Copy link

yannnz commented Oct 12, 2023

@andrewballantyne I am taking back my words. One last thing I forgot to check is the delete action. I am proposing to have the bulk action to the pipeline and pipeline version data lists, and change the Delete pipeline button to Delete depends on what are selected.
Screenshot 2023-10-12 at 12 20 18
Screenshot 2023-10-12 at 12 31 37

(This model is similar to Delete run modal )

@andrewballantyne
Copy link
Member Author

@yannnz @kywalker-rh and I talked about it on slack... we will keep the delete the same effort all around and use the toolbar kebab "delete selected" functionality. Bulk delete is bulk delete. We may need additional wording around deleting a Pipeline as all Versions will go with it (99% certain I asked the backend team of this and got that answer)

@yannnz
Copy link

yannnz commented Oct 13, 2023

@yannnz @kywalker-rh and I talked about it on slack... we will keep the delete the same effort all around and use the toolbar kebab "delete selected" functionality. Bulk delete is bulk delete. We may need additional wording around deleting a Pipeline as all Versions will go with it (99% certain I asked the backend team of this and got that answer)

@kaedward Could you help on the content of the delete modal? I tagged you in the sketch file.
https://sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/a/mPw0gLL?annotation=bcb561f4-c120-4fd8-8e71-031a6ef6b216

@yannnz
Copy link

yannnz commented Nov 18, 2023

This is the latest design link for implementation: https://www.sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/a/lRzqa1x

@kaedward There were several design updates after your latest review and needs your help. I @ you in those updates.

@dgutride
Copy link
Contributor

dgutride commented Dec 1, 2023

@dgutride
Copy link
Contributor

dgutride commented Dec 1, 2023

Moving to closed. . .

@dgutride dgutride closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ds-pipelines Data Science Pipelines feature (aka DSP) field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality migrated needs-microcopy Needs UX wording support tracker Non-completable ticket; used for tracking work - akin to a Jira Epic
Projects
Status: Done
Status: Dashboard
Archived in project
Development

No branches or pull requests

6 participants