Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: access notebook server button should behave like a link #1591

Closed
1 task done
christianvogt opened this issue Jul 26, 2023 · 5 comments · Fixed by #1675
Closed
1 task done

[Bug]: access notebook server button should behave like a link #1591

christianvogt opened this issue Jul 26, 2023 · 5 comments · Fixed by #1675
Assignees
Labels
feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33

Comments

@christianvogt
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

OpenDataHub core version (eg. v1.6.0)

Version

1.7.0

Current Behavior

The Access notebook server button on the Notebook server control panel page doesn't give direct access to the server URL for the user to be able to copy it or open the link in a new browser tab. The button isn't rendered as a link in the page but rather an action.

image

Expected Behavior

Expect all actions that perform navigation to be rendered as links to take advantage of build in browser behavior and accessibility.

Steps To Reproduce

  1. Create a notebook server
  2. navigate to the notebook control panel page /notebookController
  3. ctrl+click on the Access notebook server button
  4. Expected: a new window / tab to open
  5. Observed: content is loaded in the current tab
  6. Similarly, right click and attempt to "copy link address"
  7. Observed: no option to copy link address since the button has no href.

Workaround (if any)

  1. Duplicate the tab
  2. Click the access notebook server button

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Anything else

No response

@christianvogt christianvogt added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Jul 26, 2023
@andrewballantyne
Copy link
Member

JupyterHub design... 😞 We can look to improving it to be more a11y.

cc @kywalker-rh this is outside of everyone's SME ... you're up 🙂

@kywalker-rh
Copy link

Not sure there's much for UX to do here. Makes sense to me that we would simply change the current button to a link. I think it is mostly a transparent change, unless I am missing something.

@andrewballantyne
Copy link
Member

Not sure there's much for UX to do here. Makes sense to me that we would simply change the current button to a link. I think it is mostly a transparent change, unless I am missing something.

Okay, not sure if we want to talk about the futures of this page on this issue -- but that makes sense to me. It was designed this way because of JupyterHub some 10 months ago lol.

@Gkrumbach07 Gkrumbach07 added feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature and removed needs-ux untriaged Indicates the newly create issue has not been triaged yet labels Jul 31, 2023
@DaoDaoNoCode DaoDaoNoCode self-assigned this Aug 14, 2023
@bdattoma
Copy link

@christianvogt @andrewballantyne @kywalker-rh following the same reasoning, should also these buttons have a link attached?
image

@andrewballantyne
Copy link
Member

Well, fair -- but it doesn't matter at this point. The two buttons do what a link would do. Feel free to log a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33
Projects
Status: Done
Archived in project
Status: No status
Development

Successfully merging a pull request may close this issue.

7 participants