Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Deploy model Path field enhancements #1601

Closed
1 task done
manaswinidas opened this issue Jul 27, 2023 · 3 comments · Fixed by #1625
Closed
1 task done

[Bug]: Deploy model Path field enhancements #1601

manaswinidas opened this issue Jul 27, 2023 · 3 comments · Fixed by #1625
Assignees
Labels
feature/model-serving Model Serving Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33

Comments

@manaswinidas
Copy link
Contributor

manaswinidas commented Jul 27, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

OpenDataHub core version (eg. v1.6.0)

Version

v2.13.0

Current Behavior

Currently, the Path field has a prefix / and placeholder e.g. data that's no longer needed since we have checks in place to Prevent no-folder or root S3 model access

Expected Behavior

As discussed in #1512 (comment) and #1512 (comment), we need to remove the placeholder, and prefix / as they may no longer be needed in a no-root design.

Steps To Reproduce

  1. Select Model Serving from the left Navbar
  2. Click on Deploy server(You may have to add a model server if you haven't added one already)
  3. Go to the Path field towards the end of the Deploy server modal.

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Anything else

No response

@manaswinidas manaswinidas added kind/bug Something isn't working good first issue Good for newcomers untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Jul 27, 2023
@manaswinidas manaswinidas changed the title [Bug]: Deploy modal Folder path field enhancements [Bug]: Deploy model Path field enhancements Jul 27, 2023
@manaswinidas manaswinidas added the feature/model-serving Model Serving Feature label Jul 27, 2023
@Gkrumbach07 Gkrumbach07 removed the untriaged Indicates the newly create issue has not been triaged yet label Jul 31, 2023
@lucferbux lucferbux removed the good first issue Good for newcomers label Jul 31, 2023
@manaswinidas manaswinidas self-assigned this Aug 1, 2023
@andrewballantyne andrewballantyne modified the milestones: Current Release, Upcoming Release Aug 16, 2023
@andrewballantyne andrewballantyne removed this from the Current Release milestone Sep 15, 2023
@bdattoma
Copy link

@manaswinidas could you pls clarify what's the final decision about the leading /?

@manaswinidas
Copy link
Contributor Author

manaswinidas commented Sep 21, 2023

@bdattoma It was discussed #1625 (comment) and #1625 (comment) that we should keep the prefix so that the user knows they have to enter a path. Let me know if this answers your question.

@bdattoma
Copy link

@bdattoma It was discussed #1625 (comment) and #1625 (comment) that we should keep the prefix so that the user knows they have to enter a path. Let me know if this answers your question.

ok thanks. Sorry I misunderstood a comments in the issue you linked, so I didn't get the reason behind the decision of re-integrating the "/". Got it now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33
Projects
Status: Done
Archived in project
Status: No status
Development

Successfully merging a pull request may close this issue.

6 participants