Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tooltip with Openshift resource information for Custom Serving Runtime is misleading #1615

Closed
1 task done
bdattoma opened this issue Jul 31, 2023 · 2 comments · Fixed by #1772
Closed
1 task done
Assignees
Labels
feature/model-serving Model Serving Feature good first issue Good for newcomers kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.34

Comments

@bdattoma
Copy link

bdattoma commented Jul 31, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

Downstream version (eg. RHODS 1.29)

Version

RHODS 1.30

Current Behavior

When going hover the "Question Mark" icon on a Custom Serving Runtime, it shows a tooltip saying that we can find the resource in OCP by searching among ServingRuntime resources.
However, Custom Serving Runtimes are stored as OpenShift Template: the ServingRuntime CR instance will be created only after a model server get created and the name will correspond to the model server's instead of the Serving Runtime name.

image

Expected Behavior

the tooltip reports the OpenShift template resource information:

  • resource name: template-xxxxx
  • resource type: Template

Steps To Reproduce

  1. Log in to Dashboard with a Dashboard Admin user
  2. go to Settings > Serving runtimes
  3. find a Custom Serving Runtime if present, otherwise create one
  4. go hove the "Question Mark" icon
  5. try searching the OpenShift resource by using the information in the tooltip message

Workaround (if any)

No response

What browsers are you seeing the problem on?

Chrome

Anything else

No response

@bdattoma bdattoma added kind/bug Something isn't working priority/normal An issue with the product; fix when possible untriaged Indicates the newly create issue has not been triaged yet labels Jul 31, 2023
@lucferbux
Copy link
Contributor

Oh wow, I don't know how we missed this, thanks @bdattoma we'll triage this later but this should be a great "good first issue"

@Gkrumbach07 Gkrumbach07 added good first issue Good for newcomers feature/model-serving Model Serving Feature and removed untriaged Indicates the newly create issue has not been triaged yet labels Jul 31, 2023
@Gkrumbach07
Copy link
Member

may have conflicts with: #1476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature good first issue Good for newcomers kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.34
Projects
Status: Done
Archived in project
Status: No status
Development

Successfully merging a pull request may close this issue.

6 participants