Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: prod build includes unused monaco editor language bundles #1691

Closed
1 task done
christianvogt opened this issue Aug 22, 2023 · 0 comments · Fixed by #1688
Closed
1 task done

[Bug]: prod build includes unused monaco editor language bundles #1691

christianvogt opened this issue Aug 22, 2023 · 0 comments · Fixed by #1688
Assignees
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33

Comments

@christianvogt
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

OpenDataHub core version (eg. v1.6.0)

Version

1.8.0

Current Behavior

As per the patternfly code editor guidelines, we should specify only the languages to bundle. ODH only needs the yaml language.

While the number of extra language chunks is large, I do not believe that this has any real impact on the rest of the app since these language chunks would only be loaded on demand.

Expected Behavior

Reduced number of prod bundles excluding unused monaco editor language bundles

Steps To Reproduce

Create a prod build and observe the output files of the build.
Run webpack bundle analyzer.

image

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Anything else

No response

@christianvogt christianvogt added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Aug 22, 2023
@christianvogt christianvogt self-assigned this Aug 22, 2023
@manaswinidas manaswinidas added infrastructure Anything non feature/* related that improves general working of the Dashboard and removed untriaged Indicates the newly create issue has not been triaged yet labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants