Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When trying to display model info, all models info is displayed #1756

Closed
1 task done
FedeAlonso opened this issue Sep 6, 2023 · 4 comments · Fixed by #1777
Closed
1 task done

[Bug]: When trying to display model info, all models info is displayed #1756

FedeAlonso opened this issue Sep 6, 2023 · 4 comments · Fixed by #1777
Assignees
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) feature/model-serving Model Serving Feature kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. rhods-1.33

Comments

@FedeAlonso
Copy link

FedeAlonso commented Sep 6, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

Downstream version (eg. RHODS 1.29)

Version

RHODS 1.32.0

Current Behavior

When a User clicks on the number which represents the number of quantity of model which are deployed in a model server (in the project view), if the user has more than one model servers, the info of all deployed models (even in different servers) will be displayed.
The same happens if any of those servers has the Tokens enabled. All of them will open at the same time, showing the alert 'Tokens Disabled' in the servers which has the tokens disabled.

Peek 2023-09-06 10-22

Expected Behavior

Clicking in one model info should show just the info of the model clicked.
Same should happen with the tokens.

Steps To Reproduce

  1. login (as an admin) and go to "Data Science Projects" -> "Create new project". Fill the name of the project.
  2. Inside the project config, go down to "Models and model servers"
  3. Create one model server without Token
  4. Create one model server with token
  5. If the user clicks on the "1" displayed in the Tokens column (in the "Models and model servers" grid) all token info of both mode servers will be displayed
  6. If the user clicks on one of the zeroes displayed on the "Deployed models" column (in the "Models and model servers" grid) , it will display the message "No deployed models" in both servers.
  7. If we have deployed a model in one (or both) of the servers, then the info of the model will be displayed (e.g.: the endpoint) instead of the "No deployed models" message

Workaround (if any)

No need, it's an UX bug which does not block any info or data, but it's a little bit unintuitive.

What browsers are you seeing the problem on?

Chrome

Anything else

No response

@FedeAlonso FedeAlonso added kind/bug Something isn't working priority/normal An issue with the product; fix when possible untriaged Indicates the newly create issue has not been triaged yet labels Sep 6, 2023
@vconzola
Copy link

vconzola commented Sep 6, 2023

FWIW, this is a regression. The UI used to handle the row expansion properly.

@lucferbux
Copy link
Contributor

Ah yes, this is totally a regression, I should have realized that cause we had this issue initially, add a fix by having the state inside the component and reverted back here #1646
@DaoDaoNoCode curious why we moved the state up in the component, was it related with the scroll behaviour?

@DaoDaoNoCode
Copy link
Member

@lucferbux It's because we want to expand the Deployed models tab when the user deploys a new model to indicate the changes in the model numbers. Refer to the code here https://github.com/opendatahub-io/odh-dashboard/pull/1646/files#diff-bc437fc442f3702adee24b7c009181e5fc76d0c6156bbe770c852f326088e1c2R93. That's why we lift it up. I can look into a solution here after this ticket is triaged.

@lucferbux
Copy link
Contributor

@lucferbux It's because we want to expand the Deployed models tab when the user deploys a new model to indicate the changes in the model numbers. Refer to the code here https://github.com/opendatahub-io/odh-dashboard/pull/1646/files#diff-bc437fc442f3702adee24b7c009181e5fc76d0c6156bbe770c852f326088e1c2R93. That's why we lift it up. I can look into a solution here after this ticket is triaged.

Okk, that makes sense, perfect, we can check a solution after triage!

@DaoDaoNoCode DaoDaoNoCode added feature/model-serving Model Serving Feature rhods-1.33 priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) and removed untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Sep 11, 2023
@DaoDaoNoCode DaoDaoNoCode self-assigned this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) feature/model-serving Model Serving Feature kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. rhods-1.33
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants