Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Support v1alpha1 of AcceleratorProfiles #2007

Closed
1 task done
andrewballantyne opened this issue Oct 23, 2023 · 1 comment · Fixed by #2008
Closed
1 task done

[Bug]: Support v1alpha1 of AcceleratorProfiles #2007

andrewballantyne opened this issue Oct 23, 2023 · 1 comment · Fixed by #2008
Assignees
Labels
feature/accelerator-support All things related to Accelerators kind/bug Something isn't working priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases rhods-1.35 rhods-2.4

Comments

@andrewballantyne
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

Installing Dashboard directly (eg. v2.12.0, commit xyz, branch name)

Version

incubation

Current Behavior

We do not support existing clusters that use v1alpha1 version of the AcceleratorProfile CRs.

We migrated our AcceleratorProfile CRD to v1 in main for our stable release when we put together the official release of AcceleratorProfiles & Habana support. However we didn't consider existing installations that are using v1alpha1.

Expected Behavior

We need to support v1alpha1 (same value as v1) in the CRD & write a migration script into the backend at pod startup to convert them to v1.

This effort will have to stay at least until we write the admin view.

Steps To Reproduce

  1. Create v1alpha1 AcceleratorProfile (you'll need an older CRD)
  2. Upversion the CRD and drop v1alpha1 support

Workaround (if any)

Delete all the resources and migrate manually.

What browsers are you seeing the problem on?

No response

Anything else

No response

@andrewballantyne andrewballantyne added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/accelerator-support All things related to Accelerators and removed priority/normal An issue with the product; fix when possible labels Oct 23, 2023
@Gkrumbach07 Gkrumbach07 self-assigned this Oct 23, 2023
@andrewballantyne andrewballantyne added priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases and removed priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. labels Oct 23, 2023
@andrewballantyne
Copy link
Member Author

Upping the priority of this to reflect the need to close it out before the next release.

@dpanshug dpanshug removed the untriaged Indicates the newly create issue has not been triaged yet label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accelerator-support All things related to Accelerators kind/bug Something isn't working priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases rhods-1.35 rhods-2.4
Projects
Status: Done
Archived in project
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants