Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Hide accelerators when they are not present in the SR selection #2170

Closed
1 task done
lucferbux opened this issue Nov 16, 2023 · 2 comments
Closed
1 task done

[Bug]: Hide accelerators when they are not present in the SR selection #2170

lucferbux opened this issue Nov 16, 2023 · 2 comments
Labels
feature/accelerator-support All things related to Accelerators feature/model-serving Model Serving Feature kind/bug Something isn't working migrated priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt)

Comments

@lucferbux
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

OpenDataHub core version (eg. v1.6.0)

Version

2.4

Current Behavior

Right now we display Accelerator and Number of accelerators even when they are not selected of even present in the cluster.
Screenshot 2023-11-16 at 12 34 05

Expected Behavior

We should hide those fields when they are not added to the SR spec

Steps To Reproduce

  1. Create a kserve project
  2. Deploy a new model without selecting accelerators

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Anything else

No response
@lucferbux lucferbux added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Nov 16, 2023
@lucferbux lucferbux mentioned this issue Nov 16, 2023
Closed
@manaswinidas manaswinidas added feature/model-serving Model Serving Feature feature/accelerator-support All things related to Accelerators priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) and removed untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Nov 20, 2023
@manaswinidas
Copy link
Contributor

Triage team decided that if your cluster has no accelerator profiles, hide accelerator name and number . If it's not in use.

@dgutride
Copy link
Contributor

dgutride commented Dec 8, 2023

Migrated to: https://issues.redhat.com/browse/RHOAIENG-547

@dgutride dgutride closed this as completed Dec 8, 2023
@dgutride dgutride added migrated feature/accelerator-support All things related to Accelerators and removed feature/accelerator-support All things related to Accelerators labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/accelerator-support All things related to Accelerators feature/model-serving Model Serving Feature kind/bug Something isn't working migrated priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt)
Projects
Internal tracking
Status: Done
ODH Dashboard Planning
Archived in project
ODH Feature Tracking
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgutride @lucferbux @manaswinidas