-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: KServe microcopy #2178
Comments
@lucferbux what about changing the text which appear when user disables model serving platforms? I feel it's difficult to understand the difference between the 2 platforms from these messages:
Moreover I can see users saying "oh, I want to deploy multiple models, not only one! so I select multi-model" - I think a such choice should be helped in UI rather than requiring to read docs, which are good for getting more details if they want I would suggest the following changes:
Wdyt? |
This is probably coming a bit late in the dev cycle, but given the confusion expressed on the call: is there a compelling reason to hide the technology names? My vote would be to call them KServe and ModelMesh tbh |
@Xaenalt Hiding the technology names was part of the requirements for KServe from the BU. |
Ok, bit odd, but yeah on reflection on the copy overall, it does seem a bit confusing to the user, I think most users would probably read the titles and select multi-model serving just based on the info there, and since KServe is the overall future direction, we may want to update the language to prefer KServe somehow |
@Xaenalt For new installs KServe=ON, MM=OFF is the default selection. That should show preference for KServe. Also, this is an admin UI. Presumably, anyone working in it should have some idea of what they're doing. That said, we can improve the microcopy of the alerts to improve their readability. We can also add some additional text below each radio button option to better explain what the difference is. We'll likely add something similar to what we show on the platform selection cards in Models and Model Servers when both single and multi serving are enabled (see below). |
Maybe even Advanced Model Serving or Basic Model Serving or something, given the confusion with single/multi language, idk |
I can see that the "multi-model" and "single-model" wording can be confusing. I do think the most important point that can lead to mistakes is the one that @bdattoma mentions:
Like @Xaenalt pointed, I'm not sure if it is already too late to change terminology. Given the descriptions I can read in the shared images (specifically, this one), if there is still a chance to change terminology, I'd suggest to change:
...or something like that... trying to leave out the "platform" word, assuming ODS is the platform. IMHO, the shared/dedicated terminology will reflect with more accuracy what we are trying to communicate in the UI. |
@kaedward is out this week. So this may need to delay for the next release of KServe instead of the first one we are running at. |
@vconzola @andrewballantyne @lucferbux Lots of potential changes! I'll try to address everything mentioned here, but LMK if I miss anything or have gotten anything mixed up... 1. Model serving platform names 2. Model serving platform descriptions Multi-model: 3. Disabling model serving platforms info alerts Multi is disabled: Disabling shared model serving prevents models from being deployed from shared model servers. Instead, they will use dedicated model servers. Existing projects with deployed models will continue using their selected serving orchestrator. |
Yeah, upon reading it, I like the shared/dedicated model server orchestrator terminology |
I'm ok with "shared" and "dedicated" but the term "platform" (vs. orchestrator) comes directly from the KServe Github page - "KServe is a standard, cloud agnostic Model Inference Platform on Kubernetes, built for highly scalable use cases." @kaedward I think you have the final say here. |
Well... we already have platforms inside platforms 😉 |
@vconzola thanks! Let's keep "platform" then :-)
Multi-model:
Multi is disabled: Disabling shared model serving prevents models from being deployed from shared model servers. Instead, they will use dedicated model servers. Existing projects with deployed models will continue using their selected serving platform. |
Thanks for the suggestions, I like them. I have only some thoughts about them:
Wdyt? |
This is true, the platform does extend beyond LLMs if a user wants to install any of the other runtimes it supports. We are initially shipping with a very narrow set of things |
Migrated to https://issues.redhat.com/browse/RHOAIENG-543 |
Is there an existing issue for this?
Deploy type
OpenDataHub core version (eg.
v1.6.0
)Version
2.5
Issues
Replace all "Single model" references with "Single-model" for KServe
Right now, all the references for KServe are displayed as "Single model", but all the ModelMesh references are marked as "Multi-model" with a hyphen.
All the references for KServe to be named "Single-model" with a hyphen.
Issues in Custom Serving Runtimes Dropdown in Create view
In Custom Serving Runtimes, when adding/editing a new SR, we get this dropdown:
Change
Both single and multi-model serving platforms
forSingle-model and multi-model serving platforms
Change the width of the dropdown to be as wide as the longest label
Go to Custom Serving Runtime
Create a new Serving Runtime
Check the dropdown
Typo in Serving Runtime platform settings
Right no this is the description of the settings section for serving platform.
The correct label should display:
Select the serving platforms that can be used for deploying models on this cluster.
Typo in Custom Serving Runtimes subheader
This is the current subheader
It should say:
Manage your model serving runtimes
Wrong label in deletion modal for model serving
Right now, the deletion modal displays the following message:
It should say:
Type <name> to confirm deletion.
Wrong labels in platform selection view
These are the current labels for the platform selection view
Inconsistent empty state for kserve in global view
We currently have this empty view for a KServe Project
To have the following label:
To get started, deploy a model
The text was updated successfully, but these errors were encountered: