Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add sharing options for a notebook server #357

Closed
bdattoma opened this issue Jul 26, 2022 · 13 comments
Closed

[Feature Request]: Add sharing options for a notebook server #357

bdattoma opened this issue Jul 26, 2022 · 13 comments
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible

Comments

@bdattoma
Copy link

Feature description

As of now, a userX can access the notebook server started from a userY by using userX's credentials and without informing/warning userY.
I think it would be good to have for a user to be able to configure the access policy to their own servers. For example, userX wants to be the only one accessing their servers until they decide to share with others. (I may understand if ODH Admins can still have access to the private servers).

Describe alternatives you've considered

No response

Anything else?

No response

@bdattoma bdattoma added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet labels Jul 26, 2022
@bdattoma bdattoma changed the title [KFNBC]: Add possibility to decide the sharing options for a notebook server [KFNBC]: Add sharing options for a notebook server Jul 26, 2022
@samuelvl
Copy link
Contributor

samuelvl commented Jul 26, 2022

This will be default behavior after we merge this PR #358

  • User X will only have access to server X
  • User Y will only have access to server Y
  • ODH Admins will have access to server X and Y

@samuelvl samuelvl added feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature and removed untriaged Indicates the newly create issue has not been triaged yet labels Jul 26, 2022
@samuelvl samuelvl added this to In progress in ODH Notebook Controller Jul 26, 2022
@bdattoma
Copy link
Author

@samuelvl what about the ability of sharing access? Would it make sense?

@andrewballantyne
Copy link
Member

I do not believe Lucas' work will solve this @samuelvl -- I think @bdattoma is asking for something related to the "Project" work found in Kyle's mocks here: https://marvelapp.com/prototype/afa716d/screen/87997400

@andrewballantyne andrewballantyne added needs-info Further information is requested from the reporter or from another source priority/normal An issue with the product; fix when possible labels Jul 26, 2022
@andrewballantyne
Copy link
Member

I do not believe this is part of KFNBC

@samuelvl
Copy link
Contributor

@andrewballantyne @bdattoma Correct, sharing notebooks between users is part of the future Project initiative but it's not in KFNBC scope

@andrewballantyne andrewballantyne removed the feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature label Jul 26, 2022
@andrewballantyne andrewballantyne removed this from In progress in ODH Notebook Controller Jul 26, 2022
@andrewballantyne
Copy link
Member

I've removed it from the project then... this is something we need to address, but not part of the KFNBC work.

@andrewballantyne andrewballantyne removed the needs-info Further information is requested from the reporter or from another source label Jul 26, 2022
@andrewballantyne andrewballantyne changed the title [KFNBC]: Add sharing options for a notebook server [Feature Request]: Add sharing options for a notebook server Jul 26, 2022
@bdattoma
Copy link
Author

cool, thanks for the clarifications @andrewballantyne @samuelvl

@andrewballantyne andrewballantyne added the feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) label Aug 9, 2022
@andrewballantyne
Copy link
Member

We leaned on k8s permissions -- if you have access to the project, you'll likely have access to the workbench. No other feature level of permissions is expected here. Closing this issue as I think we achieved what we were after. If not, we can readdress this with fresh eyes.

@bdattoma
Copy link
Author

bdattoma commented Jan 30, 2023

@andrewballantyne Okay thanks.

No other feature level of permissions is expected here. Closing this issue as I think we achieved what we were after.

What about this Epic https://issues.redhat.com/browse/RHODS-1142? Wouldn't it require the same implementation of this Feature Request?

@andrewballantyne
Copy link
Member

andrewballantyne commented Jan 30, 2023

@bdattoma we should probably close that Jira ticket. Our priorities have shifted a lot in the last year and ODH will be driven by the latest desires. I highly doubt RHODS-1142 will be reused.

@bdattoma
Copy link
Author

bdattoma commented Jan 31, 2023

@bdattoma we should probably close that Jira ticket. Our priorities have shifted a lot in the last year and ODH will be driven by the latest desires. I highly doubt RHODS-1142 will be reused.

got it, thanks. I will post a comment in Jira to ask Jeff to review that Jira and close it if needed

@bdattoma
Copy link
Author

bdattoma commented Feb 1, 2023

@andrewballantyne according to Jeff this is still in plan

@andrewballantyne
Copy link
Member

Understood. This ticket will not track that effort -- when it becomes a priority we will log something new to meet the new standards / tracking we use now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible
Projects
Archived in project
Development

No branches or pull requests

4 participants