Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: configmaps -- convert errors to e.response.data.message #513

Closed
1 task done
andrewballantyne opened this issue Sep 8, 2022 · 1 comment · Fixed by #562
Closed
1 task done

[Bug]: configmaps -- convert errors to e.response.data.message #513

andrewballantyne opened this issue Sep 8, 2022 · 1 comment · Fixed by #562
Assignees
Labels
feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible
Milestone

Comments

@andrewballantyne
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

#281 is kinda our catchall to improving errors. More specifically we show errors in the logs that are just noise and will make it hard to see real issues.

Downstream issue: https://issues.redhat.com/browse/RHODS-5079

Expected Behavior

Not to show errors of 404 nature in the logs unless they are important fail points. Not getting back a configmap, secret or pvc is just that they are not there. If that's logically a bad thing, the frontend should present that to the user... but we shouldn't log it on the backend.

Three suspected changes:

  1. Avoid fastify.log when 404 in non critical usecases
  2. Still send the error back to the frontend so it can handle it
  3. Make the error message show the actual error message by digging into the e.response object -- .data.message is probably what you want

Also could we move the error handling to a .catch on the fastify.kube call that way we only need to deal with objects from the kube library and not a runtime issue with JS.

Steps To Reproduce

New user spawning a Notebook will get a 404 on configmaps and secrets. These appear in the logs and they should not.

Workaround (if any)

No response

OpenShift Infrastructure Version

No response

Openshift Version

No response

What browsers are you seeing the problem on?

No response

Open Data Hub Version

2.1

Relevant log output

No response

@andrewballantyne andrewballantyne added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature priority/normal An issue with the product; fix when possible and removed untriaged Indicates the newly create issue has not been triaged yet labels Sep 8, 2022
@andrewballantyne andrewballantyne changed the title [Bug]: configmaps/secrets/pvcs -- convert errors to e.response.data.message [Bug]: configmaps -- convert errors to e.response.data.message Sep 9, 2022
@andrewballantyne
Copy link
Member Author

Secrets and PVCs were caught in other issues -- just configmaps left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant