Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize hardcoded env var in odh-model-controller #85

Open
vaibhavjainwiz opened this issue Sep 19, 2023 · 1 comment
Open

Parametrize hardcoded env var in odh-model-controller #85

vaibhavjainwiz opened this issue Sep 19, 2023 · 1 comment

Comments

@vaibhavjainwiz
Copy link
Contributor

Currently multple Env var are hard coded to expedite implementation. These Env par should be properly parametrize to receive their there value from outside.
example :

IstioNamespace      = "istio-system"
IstioIngressService = "istio-ingressgateway"
@vaibhavjainwiz vaibhavjainwiz mentioned this issue Sep 19, 2023
Merged
3 tasks
@vaibhavjainwiz vaibhavjainwiz mentioned this issue Oct 16, 2023
Merged
3 tasks
@vaibhavjainwiz
Copy link
Contributor Author

Make labels of NetworkPolicy configurable.
https://github.com/opendatahub-io/odh-model-controller/blob/5832dbf2469408f465664d38bbb8dfc0d0310786/controllers/reconcilers/kserve_networkpolicy_reconciler.go#L64C5-L64C63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Internal tracking
Status: No status
ODH Feature Tracking
Status: No status
ODH Model Serving Planning
Status: New/Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vaibhavjainwiz