Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge kserve and modelmesh deployment modes for odh-model-controller #87

Closed
Tracked by #207
VedantMahabaleshwarkar opened this issue Sep 20, 2023 · 0 comments · Fixed by #92
Closed
Tracked by #207
Assignees

Comments

@VedantMahabaleshwarkar
Copy link
Contributor

Currently odh-model-controller is being deployed with the kserve-enabled=true flag for kserve reconciliation logic and kserve-enabled=false for modelmesh.
These flags are hardcoded in the manifests. This was done as it was not possible to deploy both kserve and modelmesh together previously. As this restriction no longer applies, we do not need the kserve-enabled flag anymore, and odh-model-controller will not need separate manifests for both components.

This is needed as ODH operator v2 is going to be pulling manifests directly from the component repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: No status
Status: Done
2 participants