Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object metrics endpoint required in admin #2480

Closed
abulte opened this issue May 23, 2020 · 0 comments · Fixed by #2484
Closed

Object metrics endpoint required in admin #2480

abulte opened this issue May 23, 2020 · 0 comments · Fixed by #2484
Assignees
@quaxsze

Comments

@abulte
Copy link
Contributor

abulte commented May 23, 2020

When refactoring the metrics we removed the object metrics endpoint, thinking we did not use it. But apparently we do: when visiting a dataset page (eg https://demo.data.gouv.fr/fr/admin/dataset/5937c5dec751df5a49c153a8), there's an XHR made to https://demo.data.gouv.fr/api/1/metrics/5937c5dec751df5a49c153a8?lang=fr&_=1590235248656 (currently a 501)

We should see what it is used for and if we need to re-implement the endpoint or remove the call and get the needed value from elsewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quaxsze quaxsze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove now useless metrics fetching quaxsze/udata
2 participants
@abulte @quaxsze