Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can S3 really be used as a storage? #2803

Open
tboye opened this issue Jan 16, 2023 · 4 comments
Open

Can S3 really be used as a storage? #2803

tboye opened this issue Jan 16, 2023 · 4 comments

Comments

@tboye
Copy link
Contributor

tboye commented Jan 16, 2023

Detailed Description

I've been playing around with udata and trying to connect multiple S3-compatible storages to it. I succeeded to certain extent but even reaching that stage already required some fixes both in udata and flask-fs.

flask-fs seems to have a nice idea of abstraction but it looks pretty immature when it comes to S3 support and the project itself is inactive, although has known issues.

Multiple questions here:

  • What do you guys use as a storage?
  • Is there a known success story with S3? I'll be happy to learn I'm doing something wrong
  • Would it be beneficial to eliminate flask-fs dependency/create a fork? Contributing doesn't seem to be an option unfortunately

Context

When I use udata, I want to have support for multiple storage types, so I could choose the one that works best for me.

Possible Implementation

See questions.

Your Environment

N/A

@quaxsze
Copy link
Contributor

quaxsze commented Jan 17, 2023

Hello,

We created a fork for flask-fs here for futher development.
Our storage is based on mongoDB so we do not have a need for an S3 storage nor plan to spend time fixing it for now.
However if you have programmed a fix for S3 on your side, feel free to make a PR on the fork.

@tboye
Copy link
Contributor Author

tboye commented Jan 17, 2023

Hi @quaxsze, thanks for your comment. The fact that you're using GridFS might explain my troubles with S3. That said, nice to know that there's a fork of flask-fs already. I still feel that S3 would be a bit more natural choice for me here, so I'll probably try to proceed with fixing it on both ends first.

Will close this issue as this was more for discussion, thanks again.

@tboye tboye closed this as completed Jan 17, 2023
@tboye
Copy link
Contributor Author

tboye commented Jan 21, 2023

@quaxsze One additional question. Nevertheless the fork exists, it seems to be not used by udata yet. When is it planned to switch to it?

@tboye tboye reopened this Jan 21, 2023
@quaxsze
Copy link
Contributor

quaxsze commented Jan 31, 2023

Well we made the fork in the first place in order to upgrade udata to flask v2. But some requirements broke and the upgrade was abandonned for a time. The forks requirements were changed to be flask v1 compatible when you opened the issue on S3.
We can switch to the fork as soon as a required feature in developped on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants