Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum field not sending values #846

Merged
merged 1 commit into from Apr 7, 2017
Merged

Fix checksum field not sending values #846

merged 1 commit into from Apr 7, 2017

Conversation

noirbizarre
Copy link
Contributor

This PR fix checksum field not exporting values to the form (missing field for checksum.type and wrong name for checksum.value)

@vinyll
Copy link
Member

vinyll commented Apr 4, 2017

Seems good with me.
However I'm never sure how a widget would react when using the usual keyboard keys (ie: up/down for combo box and enter for selecting) in form with <a @click=… in Vue.

@noirbizarre
Copy link
Contributor Author

This is not Vue.js specific (the syntax is only a shortcut on raw event handlers). Focus+Enter, Focus+space, touch event should trigger a click event on any natively clickable element (anchor, button...) (with the exception of implicite submission, ie. Enter in focused form submit even if the focus is a radio button).
But you're right, in case of an anchor, I need to check but I might need to leave the href attribute, even if empty, to make the anchor a clickable element. If so, I think I will be able to remove the cursor: pointer; CSS rule 👍

@noirbizarre
Copy link
Contributor Author

After testing, the type picker does not works on keyboard without the href. Fixed

@noirbizarre noirbizarre merged commit b4e5a3b into opendatateam:master Apr 7, 2017
@noirbizarre noirbizarre deleted the fix-checksum-component branch April 7, 2017 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants