Display badge label on dataset and org page #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
reviewed
Apr 5, 2017
udata/templates/dataset/display.html
Outdated
| @@ -190,7 +190,7 @@ <h3 class="text-left">{{ _('Producer') }}</h3> | |||
| </a> | |||
| {% for badge in dataset.badges %} | |||
| <a href="{{ url_for('front.search', badge=badge) }}"> | |||
| {{ badge }}</a>{% if not loop.last %}, {% endif %} | |||
| {{ dataset.__badges__[badge.kind] }}</a>{% if not loop.last %}, {% endif %} | |||
There was a problem hiding this comment.
Do we want to expose __private__ in templates? Why iterating over badges is not enough?
There was a problem hiding this comment.
Because the way it's done, right now badge object doesn't has access to the label :/
davidbgk
approved these changes
Apr 5, 2017
|
Changed to hide the private |
davidbgk
reviewed
Apr 5, 2017
| @@ -44,7 +44,7 @@ | |||
| <a href="{{ url_for('front.search', badge=badge) }}" | |||
| title="{{ _('See all organizations with that badge.') }}"> | |||
| <span class="glyphicon glyphicon-bookmark"></span> | |||
| {{ badge }}</a> | |||
| {{ org.badge_laebl(badge) }}</a> | |||
|
I really prefer that way, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.