Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old URLs with (at least) spaces #882

Closed
davidbgk opened this issue Apr 24, 2017 · 0 comments
Closed

Clean up old URLs with (at least) spaces #882

davidbgk opened this issue Apr 24, 2017 · 0 comments
Labels
Milestone

Comments

@davidbgk
Copy link
Member

Currently, there are issues when saving a dataset which contains resources with URLs containing spaces:

ERROR: Exception on /api/1/datasets/5369930ba3a729239d2040a4/ [PUT]
  | Traceback (most recent call last):
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
  |     rv = self.dispatch_request()
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
  |     return self.view_functions[rule.endpoint](**req.view_args)
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/flask_restplus/cors.py", line 38, in wrapped_function
  |     resp = make_response(f(*args, **kwargs))
  |   File "/Users/david/Sites/pro/etalab/udata/udata/api/__init__.py", line 97, in wrapper
  |     return func(*args, **kwargs)
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/flask_restplus/api.py", line 313, in wrapper
  |     resp = resource(*args, **kwargs)
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/flask/views.py", line 84, in view
  |     return self.dispatch_request(*args, **kwargs)
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/flask_restplus/resource.py", line 44, in dispatch_request
  |     resp = meth(*args, **kwargs)
  |   File "/Users/david/Sites/pro/etalab/udata/udata/api/__init__.py", line 88, in wrapper
  |     return func(*args, **kwargs)
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/flask_restplus/marshalling.py", line 101, in wrapper
  |     resp = f(*args, **kwargs)
  |   File "/Users/david/Sites/pro/etalab/udata/udata/core/dataset/api.py", line 133, in put
  |     return form.save()
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/flask_mongoengine/wtf/models.py", line 21, in save
  |     self.instance.save(**kwargs)
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/mongoengine/document.py", line 320, in save
  |     self.validate(clean=clean)
  |   File "/Users/david/Envs/udata/lib/python2.7/site-packages/mongoengine/base/document.py", line 402, in validate
  |     raise ValidationError(message, errors=errors)
  | ValidationError: ValidationError (Dataset:5369930ba3a729239d2040a4) (url.Invalid URL: http://www.data.rennes-metropole.fr/fileadmin/user_upload/data/Bibliotheques/prêts au 1er oct 2013.xls 1.url.Invalid URL: http://www.data.rennes-metropole.fr/fileadmin/user_upload/data/Bibliotheques/Types lecteurs.xls 2.url.Invalid URL: http://www.data.rennes-metropole.fr/fileadmin/user_upload/data/Bibliotheques/Types exemplaires.xls 3.url.Invalid URL: http://www.data.rennes-metropole.fr/fileadmin/user_upload/data/Bibliotheques/Métiers CSP.xls 4.url.Invalid URL: http://www.data.rennes-metropole.fr/fileadmin/user_upload/data/Bibliotheques/Localisation BQ.xls 6.url.Invalid URL: http://www.data.rennes-metropole.fr/fileadmin/user_upload/data/Bibliotheques/Dewey 2009 LCL.xls 7.url.Invalid URL: http://www.data.rennes-metropole.fr/fileadmin/user_upload/data/Bibliotheques/documentation_prêts au 1er oct 2013.txt: ['resources'])

A command to clean up these URLs should fix that.

@noirbizarre noirbizarre added this to the 1.0.10 milestone Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants