Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor job spec #21

Merged
merged 8 commits into from Jun 30, 2022
Merged

refactor job spec #21

merged 8 commits into from Jun 30, 2022

Conversation

konnase
Copy link
Collaborator

@konnase konnase commented Jun 28, 2022

  • refactor job spec definition and add spec.tasks to support multi tasks add tasks to dijob spec #20
  • add DI_RANK to pod env and remove engineFields in job.spec 在 Pod 内增加集群信息 #16
  • add e2e test
  • add validator to validate the correctness of dijob spec
  • change job.phase to Pending when job replicas scaled to 0
  • implement a processor to process di-server requests
  • refactor project structure

@konnase konnase self-assigned this Jun 28, 2022
@konnase konnase requested a review from Jia-zb June 28, 2022 09:53
@konnase konnase added the enhancement New feature or request label Jun 28, 2022
Copy link
Collaborator

@Jia-zb Jia-zb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@konnase konnase requested a review from EastInsure June 28, 2022 12:11
@konnase konnase merged commit 02c5aae into opendilab:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants