Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo in the comment of _ucb_score #157

Closed
gohsyi opened this issue Dec 4, 2023 · 2 comments
Closed

A typo in the comment of _ucb_score #157

gohsyi opened this issue Dec 4, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation typo Fix typo

Comments

@gohsyi
Copy link

gohsyi commented Dec 4, 2023

https://github.com/opendilab/LightZero/blame/3d8fb0b22249aec9e80b7eeac80b83df2b68710f/lzero/mcts/ptree/ptree_az.py#L405

N(\text{parent}) should be \sqrt{N(\text{parent})}
@puyuan1996
Copy link
Collaborator

Hello, thank you very much for your attention and feedback. We will fix this error in future updates. If you have any suggestions for improvement, please feel free to provide them. Best wishes!

@puyuan1996 puyuan1996 added typo Fix typo documentation Improvements or additions to documentation labels Dec 4, 2023
@puyuan1996
Copy link
Collaborator

We have fixed this typo in #160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation typo Fix typo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gohsyi @puyuan1996