Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Function names are case-sensitive #233

Closed
jordanw-bq opened this issue Oct 18, 2019 · 3 comments
Closed

Function names are case-sensitive #233

jordanw-bq opened this issue Oct 18, 2019 · 3 comments
Assignees
Labels
BI integration Issues for integration with BI tools bug Something isn't working good first issue Good for newcomers

Comments

@jordanw-bq
Copy link
Contributor

Using Docker image amazon/opendistro-for-elasticsearch:1.1.0
Dataset: Flights sample data (loaded through Kibana)
SQL Plugin version: 1.1.0.1

Example Query:
SELECT SUBSTRING(OriginWeather, 1, 2) FROM kibana_sample_data_flights

Result:

Internal Server Error. Reason: There was internal problem at backend. Type: UnsupportedOperationException. Details: The following method is not supported in Schema: SUBSTRING
	at com.amazon.opendistroforelasticsearch.jdbc.StatementImpl.executeQueryRequest(StatementImpl.java:78)
	at com.amazon.opendistroforelasticsearch.jdbc.StatementImpl.executeQueryX(StatementImpl.java:61)
	at com.amazon.opendistroforelasticsearch.jdbc.StatementImpl.execute(StatementImpl.java:170)

Note:
SELECT substring(OriginWeather, 1, 2)... returns results as intended.

Expectation:
Tableau will use UPPERCASE function names in almost all cases. Casing should not matter for function names in a query.

@dai-chen
Copy link
Member

Actually both our old and new parser are case-insensitive to function name. This issue is similar as #224 and thrown from our JDBC formatter.

@dai-chen dai-chen added BI integration Issues for integration with BI tools enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Oct 18, 2019
@dai-chen
Copy link
Member

Just checked our formatter seems match function name in case sensitive way (simply look it up in hash set).

@dai-chen dai-chen added the good first issue Good for newcomers label Oct 18, 2019
@galkk
Copy link
Contributor

galkk commented Oct 18, 2019

related to #176

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BI integration Issues for integration with BI tools bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants