Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect display on for each scenario in the earthquake scenarios GitHub page, dead links #84

Closed
wkhchow opened this issue Aug 14, 2023 · 0 comments · Fixed by #89
Closed

Incorrect display on for each scenario in the earthquake scenarios GitHub page, dead links #84

wkhchow opened this issue Aug 14, 2023 · 0 comments · Fixed by #89
Assignees
@anthonyfok
Labels
Bug Something isn't working
Projects
Data

Comments

@wkhchow
Copy link
Collaborator

wkhchow commented Aug 14, 2023

Newest GitHub page for earthquake scenarios display syntax for each scenario.
image

For the new 13 scenarios, the download links are broken as its referencing v1.2.2 release asset which those scenarios did not exist, and only in v1.2.3.
@wkhchow wkhchow added the Bug Something isn't working label Aug 14, 2023
@wkhchow wkhchow added this to Planned in Data via automation Aug 14, 2023
anthonyfok added a commit to anthonyfok/earthquake-scenarios that referenced this issue Jan 23, 2024
@anthonyfok
gh-pages: Fix scenario titles by using scenario.title[page.lang]
405fb7d 
In commit bdb5170, docs/_data/dsra.yml
was restructured where scenario.title was changed from an English string
to two children nodes of "en" and "fr" to accommodate the French titles.

However, I failed to replace scenario.title with scenario.title[page.lang]
in the Markdown files accordingly, leading to strange display of scenario
titles such as {"en"=>"M7.1 Sidney (BC)", "fr"=>"M7,1 à Sidney (C.-B.)"},
for example.

Fixes OpenDRR#84
@anthonyfok anthonyfok mentioned this issue Jan 23, 2024
Merged
Data automation moved this from Planned to Published Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonyfok anthonyfok

Labels
Bug Something isn't working
Projects
Data
Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-pages: Fix scenario titles by using scenario.title[page.lang] anthonyfok/earthquake-scenarios
2 participants
@anthonyfok @wkhchow