Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Add a new flag to charts that will disable legacy components #235

Closed
kmova opened this issue Jul 18, 2021 · 1 comment
Closed

Add a new flag to charts that will disable legacy components #235

kmova opened this issue Jul 18, 2021 · 1 comment
Assignees
@shovanmaity

Comments

@kmova
Copy link
Member

kmova commented Jul 18, 2021

To disable deprecated components, multiple values need to be specified like

--set webhook.enabled=false \
--set snapshotOperator.enabled=false \
--set provisioner.enabled=false \
--set apiserver.enabled=false \

It would be nice to add a new variable that can replace all the above. For all the above flags, use this new flag with default=true in (and)

--set legacy.enabled=true

The workflow to migrate from legacy to new components can be as follows:

  • Enable new driver:
    helm upgrade ... --resuse-values --set cstor.enabled=true
  • Migrate older pools and volumes to new drivers
  • Disable legacy components
    helm upgrade ... --resuse-values --set legacy.enabled=false
@kmova kmova added this to Pre-commits and Designs - Due: July 31 2021 in 2.12 Release Tracker - Due Aug 15th. Jul 18, 2021
@kmova kmova mentioned this issue Jul 18, 2021
Closed
4 tasks
@shovanmaity shovanmaity mentioned this issue Jul 22, 2021
Merged
@prateekpandey14 prateekpandey14 moved this from Pre-commits and Designs - Due: July 31 2021 to RC2 - Due: Aug 8 2021 in 2.12 Release Tracker - Due Aug 15th. Aug 10, 2021
@prateekpandey14 prateekpandey14 moved this from RC2 - Due: Aug 8 2021 to Release Items in 2.12 Release Tracker - Due Aug 15th. Aug 17, 2021
@kmova
Copy link
Member Author

kmova commented Aug 18, 2021

Tested by having all the flags enabled and creating some jiva csi volumes.

kiran_mova_mayadata_io@kmova-dev:openebs-localpv$ kubectl get pods -n openebs
NAME                                                              READY   STATUS    RESTARTS   AGE
alertmanager-openebs-monitoring-kube-pr-alertmanager-0            2/2     Running   0          43h
hostpath-list                                                     1/1     Running   0          22m
openebs-admission-server-847859f8c7-2ngjc                         1/1     Running   0          3d7h
openebs-apiserver-d4cf95fbb-dljpx                                 1/1     Running   0          3d7h
openebs-cstor-admission-server-77754bd999-s65lr                   1/1     Running   0          3d7h
openebs-cstor-csi-controller-0                                    6/6     Running   0          3d7h
openebs-cstor-csi-node-4cwmz                                      2/2     Running   0          3d7h
openebs-cstor-csi-node-sdlmx                                      2/2     Running   0          3d7h
openebs-cstor-csi-node-wfjp2                                      2/2     Running   0          3d7h
openebs-cstor-cspc-operator-7695c9d468-jclhg                      1/1     Running   0          3d7h
openebs-cstor-cvc-operator-d7fd4c76c-46rjf                        1/1     Running   0          3d7h
openebs-jiva-csi-controller-0                                     5/5     Running   0          3d7h
openebs-jiva-csi-node-2482h                                       3/3     Running   0          3d7h
openebs-jiva-csi-node-l7tsh                                       3/3     Running   0          3d7h
openebs-jiva-csi-node-scn2c                                       3/3     Running   0          3d7h
openebs-jiva-operator-5f47f696cc-cmfbv                            1/1     Running   0          3d7h
openebs-localpv-provisioner-5d9964f599-4cg9f                      1/1     Running   0          3d7h
openebs-monitoring-grafana-6b9748bf-mrgxc                         2/2     Running   0          43h
openebs-monitoring-kube-pr-operator-747d8dcc47-6xp7f              1/1     Running   0          43h
openebs-monitoring-kube-state-metrics-6cf5d7cc99-r9ztp            1/1     Running   0          43h
openebs-monitoring-node-problem-detector-2lzkj                    1/1     Running   0          43h
openebs-monitoring-node-problem-detector-hjsgr                    1/1     Running   0          43h
openebs-monitoring-node-problem-detector-p7zms                    1/1     Running   0          43h
openebs-monitoring-prometheus-node-exporter-99s28                 1/1     Running   0          43h
openebs-monitoring-prometheus-node-exporter-9cmvj                 1/1     Running   0          43h
openebs-monitoring-prometheus-node-exporter-tq4vg                 1/1     Running   0          43h
openebs-ndm-2hqw5                                                 1/1     Running   0          3d7h
openebs-ndm-d756z                                                 1/1     Running   0          3d7h
openebs-ndm-mh9pf                                                 1/1     Running   0          3d7h
openebs-ndm-operator-65647cbb99-r5b85                             1/1     Running   0          3d7h
openebs-provisioner-56c9bbbf65-tjg45                              1/1     Running   0          3d7h
openebs-snapshot-operator-7d7558dfc8-65frm                        2/2     Running   0          3d7h
prometheus-openebs-monitoring-kube-pr-prometheus-0                2/2     Running   1          43h
pvc-31ba6eec-2d3d-4d0e-9bfa-04b3acf071e5-jiva-ctrl-689d9798cr9j   2/2     Running   0          43h
pvc-31ba6eec-2d3d-4d0e-9bfa-04b3acf071e5-jiva-rep-0               1/1     Running   0          43h
pvc-c3fcb42a-bcf8-4d68-8f7c-c51de3112ee8-jiva-ctrl-598bd9ftpv7x   2/2     Running   0          43h
pvc-c3fcb42a-bcf8-4d68-8f7c-c51de3112ee8-jiva-rep-0               1/1     Running   0          43h
pvc-c8e1c0f8-9e45-4eec-a774-1aeaa68c9dda-jiva-ctrl-648ddd8cz8tv   2/2     Running   0          43h
pvc-c8e1c0f8-9e45-4eec-a774-1aeaa68c9dda-jiva-rep-0               1/1     Running   0          43h

Tried to remove the legacy components with the following command:

helm upgrade openebs openebs/openebs  --set legacy.enabled=false --reuse-values --namespace openebs

The older components - apiserver, admissionserver, provisioner and k8s snapshotter are removed.

kiran_mova_mayadata_io@kmova-dev:openebs-localpv$ kubectl get pods -n openebs
NAME                                                              READY   STATUS    RESTARTS   AGE
alertmanager-openebs-monitoring-kube-pr-alertmanager-0            2/2     Running   0          43h
hostpath-list                                                     1/1     Running   0          27m
openebs-cstor-admission-server-77754bd999-s65lr                   1/1     Running   0          3d7h
openebs-cstor-csi-controller-0                                    6/6     Running   0          3d7h
openebs-cstor-csi-node-4cwmz                                      2/2     Running   0          3d7h
openebs-cstor-csi-node-sdlmx                                      2/2     Running   0          3d7h
openebs-cstor-csi-node-wfjp2                                      2/2     Running   0          3d7h
openebs-cstor-cspc-operator-7695c9d468-jclhg                      1/1     Running   0          3d7h
openebs-cstor-cvc-operator-d7fd4c76c-46rjf                        1/1     Running   0          3d7h
openebs-jiva-csi-controller-0                                     5/5     Running   0          3d7h
openebs-jiva-csi-node-2482h                                       3/3     Running   0          3d7h
openebs-jiva-csi-node-l7tsh                                       3/3     Running   0          3d7h
openebs-jiva-csi-node-scn2c                                       3/3     Running   0          3d7h
openebs-jiva-operator-5f47f696cc-cmfbv                            1/1     Running   0          3d7h
openebs-localpv-provisioner-5d9964f599-4cg9f                      1/1     Running   0          3d7h
openebs-monitoring-grafana-6b9748bf-mrgxc                         2/2     Running   0          43h
openebs-monitoring-kube-pr-operator-747d8dcc47-6xp7f              1/1     Running   0          43h
openebs-monitoring-kube-state-metrics-6cf5d7cc99-r9ztp            1/1     Running   0          43h
openebs-monitoring-node-problem-detector-2lzkj                    1/1     Running   0          43h
openebs-monitoring-node-problem-detector-hjsgr                    1/1     Running   0          43h
openebs-monitoring-node-problem-detector-p7zms                    1/1     Running   0          43h
openebs-monitoring-prometheus-node-exporter-99s28                 1/1     Running   0          43h
openebs-monitoring-prometheus-node-exporter-9cmvj                 1/1     Running   0          43h
openebs-monitoring-prometheus-node-exporter-tq4vg                 1/1     Running   0          43h
openebs-ndm-2hqw5                                                 1/1     Running   0          3d7h
openebs-ndm-d756z                                                 1/1     Running   0          3d7h
openebs-ndm-mh9pf                                                 1/1     Running   0          3d7h
openebs-ndm-operator-65647cbb99-r5b85                             1/1     Running   0          3d7h
prometheus-openebs-monitoring-kube-pr-prometheus-0                2/2     Running   1          43h
pvc-31ba6eec-2d3d-4d0e-9bfa-04b3acf071e5-jiva-ctrl-689d9798cr9j   2/2     Running   0          43h
pvc-31ba6eec-2d3d-4d0e-9bfa-04b3acf071e5-jiva-rep-0               1/1     Running   0          43h
pvc-c3fcb42a-bcf8-4d68-8f7c-c51de3112ee8-jiva-ctrl-598bd9ftpv7x   2/2     Running   0          43h
pvc-c3fcb42a-bcf8-4d68-8f7c-c51de3112ee8-jiva-rep-0               1/1     Running   0          43h
pvc-c8e1c0f8-9e45-4eec-a774-1aeaa68c9dda-jiva-ctrl-648ddd8cz8tv   2/2     Running   0          43h
pvc-c8e1c0f8-9e45-4eec-a774-1aeaa68c9dda-jiva-rep-0               1/1     Running   0          43h

@kmova kmova closed this as completed Aug 18, 2021
2.12 Release Tracker - Due Aug 15th. automation moved this from Release Items to Done Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shovanmaity shovanmaity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmova @shovanmaity