Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event): update ua to ga4 analytics #174

Merged

Conversation

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b35af76) 50.17% compared to head (7ca320c) 49.94%.
Report is 4 commits behind head on develop.

Files Patch % Lines
provisioner/provisioner.go 0.00% 8 Missing ⚠️
provisioner/controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
- Coverage    50.17%   49.94%   -0.24%     
===========================================
  Files           38       38              
  Lines         2792     2805      +13     
===========================================
  Hits          1401     1401              
- Misses        1285     1298      +13     
  Partials       106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

niladrih

This comment was marked as outdated.

provisioner/provisioner.go Outdated Show resolved Hide resolved
@dsharma-dc
Copy link
Contributor

@Abhinandan-Purkait Perhaps you should squash the commit 7ca320c into some previous commit.

@Abhinandan-Purkait
Copy link
Contributor Author

Abhinandan-Purkait commented Dec 7, 2023

@Abhinandan-Purkait Perhaps you should squash the commit 7ca320c into some previous commit.

@dsharma-dc I will do a squash and merge. Waiting for the ci to complete.

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait Abhinandan-Purkait merged commit 57d69ea into openebs-archive:develop Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants