[US3990]refactor:(cstor-operator): refactor cstor operator #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will do following: 1. Iteration for pool creation will not happen at runtasks rather cstor-operator will one by one create pools to converge to maxPool count. 2. minPool field in SPC is deprecated. Providing minPool field in SPC won't do any thing. 3. maxPool field for manual provisioning is manadatory now to support reconciliation for manual provisioned pool. 4. Reconciliation has been added to manual provisioned pool. Signed-off-by: sonasingh46 <sonasingh46@gmail.com>
sonasingh46
added
WIP
pr/release-note
Codecov Report
@@ Coverage Diff @@
## master #867 +/- ##
==========================================
- Coverage 42.27% 42.12% -0.15%
==========================================
Files 141 141
Lines 9380 9275 -105
==========================================
- Hits 3965 3907 -58
+ Misses 5149 5103 -46
+ Partials 266 265 -1
Continue to review full report at Codecov.
|
AmitKumarDas
suggested changes
Dec 18, 2018
There was a problem hiding this comment.
@sonasingh46 I have provided some comments.
Comments on name of custom resources needs to be resolved.
sonasingh46
force-pushed
the
refactor-cstor-operator
branch
from
351f4fc
to
8a357e4
Compare
Signed-off-by: sonasingh46 <sonasingh46@gmail.com>
sonasingh46
force-pushed
the
refactor-cstor-operator
branch
from
cbc19e9
to
ee5f590
Compare
AmitKumarDas
approved these changes
Dec 20, 2018
kmova
reviewed
Dec 22, 2018
|
|
||
| // If current pool count is less than maxpool count, try to converge to maxpool | ||
| if currentPoolCount < int(spcGot.Spec.MaxPools) { | ||
| maxPoolCount := int(spcGot.Spec.MaxPools) |
There was a problem hiding this comment.
Since manual pool SPC didn't have this in 0.8, test if the upgrade will cause a failure here?
There was a problem hiding this comment.
It should not cause but I will test it.
sonasingh46
changed the title
Signed-off-by: sonasingh46 <sonasingh46@gmail.com>
kmova
reviewed
Dec 31, 2018
| // validate can mutate spc object -- for example if maxPool field is not present in case | ||
| // of auto provisioning, maxPool will default to 3. | ||
| // We need to immediately patch SPC object here. | ||
| if mutateSpc && !resync { |
There was a problem hiding this comment.
Will this case cause any issue with the following scenario:
- maya-apiserver (cstor-operator) is down
- SPC yaml is applied.
What does resync variable indicate?
Signed-off-by: sonasingh46 <sonasingh46@gmail.com>
kmova
approved these changes
Jan 2, 2019
sonasingh46
added a commit
to sonasingh46/maya
that referenced
this pull request
Jan 21, 2019
…rchive#867) * refactor:(cstor-operator): refactor cstor operator This commit will do following: 1. Iteration for pool creation will not happen at runtasks rather cstor-operator will one by one create pools to converge to maxPool count. 2. minPool field in SPC is deprecated. Providing minPool field in SPC won't do any thing. 3. maxPool field for manual provisioning is manadatory now to support reconciliation for manual provisioned pool. 4. Reconciliation has been added to manual provisioned pool. Signed-off-by: sonasingh46 <sonasingh46@gmail.com>
vishnuitta
pushed a commit
that referenced
this pull request
Jan 25, 2019
* refactor:(cstor-operator): refactor cstor operator This commit will do following: 1. Iteration for pool creation will not happen at runtasks rather cstor-operator will one by one create pools to converge to maxPool count. 2. minPool field in SPC is deprecated. Providing minPool field in SPC won't do any thing. 3. maxPool field for manual provisioning is manadatory now to support reconciliation for manual provisioned pool. 4. Reconciliation has been added to manual provisioned pool. Signed-off-by: sonasingh46 <sonasingh46@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will do following:
Iteration for pool creation will not happen at runtasks
rather cstor-operator will one by one create pools to converge
to maxPool count.
minPool field in SPC is deprecated. Providing minPool field in
SPC won't do any thing.
Reconciliation has been added to manual provisioned pool.
Signed-off-by: sonasingh46 sonasingh46@gmail.com