Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndm_daemonset/probe Unit test fail #654

Open
superleo opened this issue Oct 12, 2021 · 0 comments
Open

ndm_daemonset/probe Unit test fail #654

superleo opened this issue Oct 12, 2021 · 0 comments

Comments

@superleo
Copy link

superleo commented Oct 12, 2021

Unit test Fail:
ENV: Centos7.9

  1. run:

sudo -E env "PATH=$PATH" go test github.com/openebs/node-disk-manager/cmd/ndm_daemonset/probe

  1. get:

`I1012 21:32:25.751120 593649 probe.go:89] configured fake-probe : state enable
--- FAIL: TestFillDiskDetailsBySmart (0.00s)
smartprobe_test.go:92: the device type is not supported yet, device type: "unknown"
--- FAIL: TestFillDiskDetails (0.00s)
udevprobe_test.go:137:
Error Trace: udevprobe_test.go:137
Error: Not equal:
expected: &blockdevice.BlockDevice{Identifier:blockdevice.Identifier{UUID:"", SysPath:"/sys/dev/block/253:0", DevPath:"/dev/dm-0"}, NodeAttributes:blockdevice.NodeAttribute(nil), Labels:map[string]string(nil), FSInfo:blockdevice.FileSystemInformation{FileSystemUUID:"", FileSystem:"", MountPoint:[]string(nil)}, Capacity:blockdevice.CapacityInformation{Storage:0x0}, DevLinks:[]blockdevice.DevLink(nil), DeviceAttributes:blockdevice.DeviceAttribute{DeviceType:"", DriveType:"", IDType:"", PhysicalBlockSize:0x0, LogicalBlockSize:0x0, HardwareSectorSize:0x0, WWN:"", Vendor:"", Model:"", Serial:"", FirmwareRevision:"", Compliance:""}, DMInfo:blockdevice.DeviceMapperInformation{DMUUID:"", DevMapperPath:""}, DevUse:blockdevice.DeviceUsage{InUse:false, UsedBy:""}, PartitionInfo:blockdevice.PartitionInformation{PartitionNumber:0x0, PartitionEntryUUID:"", PartitionTableUUID:"", PartitionTableType:""}, DependentDevices:blockdevice.DependentBlockDevices{Parent:"", Partitions:[]string(nil), Holders:[]string(nil), Slaves:[]string(nil)}, SMARTInfo:blockdevice.SMARTStats{RotationRate:0x0, RotationalLatency:0, TemperatureInfo:blockdevice.TemperatureInformation{CurrentTemperatureDataValid:false, LowestTemperatureDataValid:false, HighestTemperatureDataValid:false, CurrentTemperature:0, LowestTemperature:0, HighestTemperature:0}, TotalBytesRead:0x0, TotalBytesWritten:0x0, UtilizationRate:0, PercentEnduranceUsed:0}, Status:blockdevice.Status{State:"", ClaimPhase:""}}
actual : &blockdevice.BlockDevice{Identifier:blockdevice.Identifier{UUID:"", SysPath:"/sys/dev/block/253:0", DevPath:"/dev/dm-0"}, NodeAttributes:blockdevice.NodeAttribute(nil), Labels:map[string]string(nil), FSInfo:blockdevice.FileSystemInformation{FileSystemUUID:"", FileSystem:"xfs", MountPoint:[]string(nil)}, Capacity:blockdevice.CapacityInformation{Storage:0x0}, DevLinks:[]blockdevice.DevLink(nil), DeviceAttributes:blockdevice.DeviceAttribute{DeviceType:"", DriveType:"", IDType:"", PhysicalBlockSize:0x0, LogicalBlockSize:0x0, HardwareSectorSize:0x0, WWN:"", Vendor:"", Model:"", Serial:"", FirmwareRevision:"", Compliance:""}, DMInfo:blockdevice.DeviceMapperInformation{DMUUID:"", DevMapperPath:"/dev/mapper/centos-root"}, DevUse:blockdevice.DeviceUsage{InUse:false, UsedBy:""}, PartitionInfo:blockdevice.PartitionInformation{PartitionNumber:0x0, PartitionEntryUUID:"", PartitionTableUUID:"", PartitionTableType:""}, DependentDevices:blockdevice.DependentBlockDevices{Parent:"", Partitions:[]string(nil), Holders:[]string(nil), Slaves:[]string(nil)}, SMARTInfo:blockdevice.SMARTStats{RotationRate:0x0, RotationalLatency:0, TemperatureInfo:blockdevice.TemperatureInformation{CurrentTemperatureDataValid:false, LowestTemperatureDataValid:false, HighestTemperatureDataValid:false, CurrentTemperature:0, LowestTemperature:0, HighestTemperature:0}, TotalBytesRead:0x0, TotalBytesWritten:0x0, UtilizationRate:0, PercentEnduranceUsed:0}, Status:blockdevice.Status{State:"", ClaimPhase:""}}

                            Diff:
                            --- Expected
                            +++ Actual
                            @@ -10,3 +10,3 @@
                               FileSystemUUID: (string) "",
                            -  FileSystem: (string) "",
                            +  FileSystem: (string) (len=3) "xfs",
                               MountPoint: ([]string) <nil>
                            @@ -33,3 +33,3 @@
                               DMUUID: (string) "",
                            -  DevMapperPath: (string) ""
                            +  DevMapperPath: (string) (len=23) "/dev/mapper/centos-root"
                              },
            Test:           TestFillDiskDetails

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants