fix(filter): add default vendor OpenEBS in vendor filter #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilerm
added this to Pre-commits and Designs - Due: Apr 30 2020
in 1.10 Release Tracker - Due May 15th.
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
- Coverage 46.79% 46.66% -0.13%
==========================================
Files 59 59
Lines 2669 2670 +1
==========================================
- Hits 1249 1246 -3
- Misses 1322 1325 +3
- Partials 98 99 +1
Continue to review full report at Codecov.
|
kmova
previously approved these changes
Apr 28, 2020
kmova
reviewed
Apr 28, 2020
- add OpenEBS as a default vendor in vendor filter - modify test cases to add OpenEBS as a default vendor Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
akhilerm
force-pushed
the
default-vendor-filter
branch
from
7da77e3
to
6759550
Compare
richardelling
approved these changes
Apr 28, 2020
kmova
approved these changes
Apr 28, 2020
1.10 Release Tracker - Due May 15th.
automation
moved this from Pre-commits and Designs - Due: Apr 30 2020
to Done
Apr 28, 2020
This was referenced May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
Why is this PR required? What issue does it fix?:
This PR adds
OpenEBSto the list of default excluded vendors. This is done so that, even if user removes the vendor filter, OpenEBS created iscsi disks are excluded by NDM.What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
None
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>