fix(controller): add finalizer to claimed BD #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilerm
added
bug
add openebs.io/bd-protection finalizer to BDs that are in claimed state to prevent accidental deletion Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 44.24% 44.78% +0.54%
==========================================
Files 59 59
Lines 2839 2869 +30
==========================================
+ Hits 1256 1285 +29
- Misses 1479 1482 +3
+ Partials 104 102 -2
Continue to review full report at Codecov.
|
kmova
reviewed
May 6, 2020
| err := r.updateBDStatus(openebsv1alpha1.BlockDeviceUnclaimed, instance) | ||
| if err != nil { | ||
| reqLogger.Error(err, "marking blockdevice "+instance.Name+" as Unclaimed failed") | ||
| } | ||
| } | ||
| case openebsv1alpha1.BlockDeviceClaimed: | ||
| if !util.Contains(instance.GetFinalizers(), controllerutil.BlockDeviceFinalizer) { | ||
| // finalizer is not present, may be a BlockDevice claimed from previous release |
kmova
approved these changes
May 6, 2020
1.10 Release Tracker - Due May 15th.
automation
moved this from RC1 - Due: May 5 2020
to Done
May 6, 2020
This was referenced May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
Pull Request template
Why is this PR required? What issue does it fix?:
When a user deletes a BD that is claimed, the BD will be automatically recreated by NDM daemon pod. But the recreated BD will be in Unclaimed state. Thus another claim can get bound to the same BD resulting in data corruption.
What this PR does?:
openebs.io/bd-protectionfinalizer to BDs that are inClaimedstateDoes this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>