Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install, crd): add env to enable/disable CRD installation #421

Merged
merged 1 commit into from
May 12, 2020

Conversation

akhilerm
Copy link
Contributor

Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io

Why is this PR required? What issue does it fix?:
When helm install for openebs was introduced, there was no way for helm to install CRDs. So both maya api-server and NDM had code to install the respective CRDs as part of initialization.

With Helm 3, the CRDs can be installed via helm. There have been some requests for moving the CRD installations outside of the code for cases where Kubernetes installers like Lokomotive and others, would like granular control on how the required objects are installed.

What this PR does?:

  • add OPENEBS_IO_CRD_INSTALL environment variable to enable / disable
    installation of BlockDevice and BlockDeviceClaim CRDs

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
#1693

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

add OPENEBS_IO_CRD_INSTALL environment variable to enable / disable
installation of BlockDevice and BlockDeviceClaim CRDs

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@codecov-io
Copy link

Codecov Report

Merging #421 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   44.33%   44.43%   +0.09%     
==========================================
  Files          59       60       +1     
  Lines        2853     2858       +5     
==========================================
+ Hits         1265     1270       +5     
  Misses       1486     1486              
  Partials      102      102              
Impacted Files Coverage Δ
pkg/env/env.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59ce1d...5e4e48a. Read the comment docs.

@akhilerm akhilerm added this to RC2 - Due May 10, 2020 in 1.10 Release Tracker - Due May 15th. May 12, 2020
@akhilerm akhilerm added this to In Review in NDM May 12, 2020
@kmova kmova merged commit 8424417 into openebs-archive:master May 12, 2020
NDM automation moved this from In Review to Done May 12, 2020
1.10 Release Tracker - Due May 15th. automation moved this from RC2 - Due May 10, 2020 to Done May 12, 2020
@akhilerm akhilerm deleted the install-crd-env branch December 13, 2021 05:50
@Abhinandan-Purkait Abhinandan-Purkait removed this from Done in NDM Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants