refactor(pkg, udevevent): decouple udevevent from controller #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per conventions, packages in the pkg directory should be independent of the overlying applications that use them. The `udevevent` package has tight coupling with the `controller` and `probe` packages from ndm_daemonset. Refactor to make `udevevent` standalone. This includes moving all application (ndm_daemonset in this case) specific code in `udevevent` to appropriate cmd packages and providing an API for the application code to use the functionalities of `udevevent`. Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
z0marlin
commented
Jul 22, 2021
| @@ -19,10 +19,10 @@ package controller | |||
| import ( | |||
| "sort" | |||
|
|
|||
| "k8s.io/klog" | |||
There was a problem hiding this comment.
reordering as per convention
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
==========================================
- Coverage 48.11% 46.38% -1.73%
==========================================
Files 79 78 -1
Lines 3720 3781 +61
==========================================
- Hits 1790 1754 -36
- Misses 1770 1871 +101
+ Partials 160 156 -4
Continue to review full report at Codecov.
|
akhilerm
added this to Pre-commits and Designs - Due: July 31 2021
in 2.12 Release Tracker - Due Aug 15th.
akhilerm
reviewed
Jul 27, 2021
akhilerm
reviewed
Jul 27, 2021
akhilerm
reviewed
Jul 27, 2021
akhilerm
reviewed
Jul 27, 2021
akhilerm
reviewed
Jul 27, 2021
akhilerm
reviewed
Jul 27, 2021
akhilerm
reviewed
Jul 27, 2021
akhilerm
reviewed
Jul 27, 2021
Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
- use action constant strings from pkg udev - add inline comments Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
RealHarshThakur
approved these changes
Aug 3, 2021
akhilerm
reviewed
Aug 3, 2021
akhilerm
reviewed
Aug 3, 2021
2.12 Release Tracker - Due Aug 15th.
automation
moved this from Pre-commits and Designs - Due: July 31 2021
to Done
Aug 5, 2021
Ab-hishek
pushed a commit
to Ab-hishek/node-disk-manager
that referenced
this pull request
Aug 13, 2021
…-archive#609) As per conventions, packages in the pkg directory should be independent of the overlying applications that use them. The `udevevent` package has tight coupling with the `controller` and `probe` packages from ndm_daemonset. Refactor to make `udevevent` standalone. This includes moving all application (ndm_daemonset in this case) specific code in `udevevent` to appropriate cmd packages and providing an API for the application code to use the functionalities of `udevevent`. - remove logging from package - reuse action constants from pkg udev - add inline comments Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
Ab-hishek
pushed a commit
to Ab-hishek/node-disk-manager
that referenced
this pull request
Aug 13, 2021
…-archive#609) As per conventions, packages in the pkg directory should be independent of the overlying applications that use them. The `udevevent` package has tight coupling with the `controller` and `probe` packages from ndm_daemonset. Refactor to make `udevevent` standalone. This includes moving all application (ndm_daemonset in this case) specific code in `udevevent` to appropriate cmd packages and providing an API for the application code to use the functionalities of `udevevent`. - remove logging from package - reuse action constants from pkg udev - add inline comments Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
akhilerm
pushed a commit
that referenced
this pull request
Aug 13, 2021
…614) As per conventions, packages in the pkg directory should be independent of the overlying applications that use them. The `udevevent` package has tight coupling with the `controller` and `probe` packages from ndm_daemonset. Refactor to make `udevevent` standalone. This includes moving all application (ndm_daemonset in this case) specific code in `udevevent` to appropriate cmd packages and providing an API for the application code to use the functionalities of `udevevent`. - remove logging from package - reuse action constants from pkg udev - add inline comments Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com> Co-authored-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per conventions, packages in the pkg directory should be independent
of the overlying applications that use them. The
udeveventpackage hastight coupling with the
controllerandprobepackages fromndm_daemonset.
Refactor to make
udeveventstandalone. This includesmoving all application (ndm_daemonset in this case) specific code in
udeveventto appropriate cmd packages and providing an API for theapplication code to use the functionalities of
udevevent.This PR aligns with the idea raised in #597
Signed-off-by: Aditya Jain aditya.jainadityajain.jain@gmail.com
Checklist:
<type>(<scope>): <subject>