Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): replace github.com/ghodss/yaml with sigs.k8s.io/yaml #687

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Feb 9, 2023

This includes @Juneezee's changes in PR #685 and a changelog commit for the same. This PR sits on top of the CI fixes from #686 .

Signed-off-by: Niladri Halder niladri.halder26@gmail.com

Juneezee and others added 2 commits February 9, 2023 13:42
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #687 (d89201f) into develop (da2a5b9) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #687      +/-   ##
===========================================
- Coverage    45.34%   45.26%   -0.08%     
===========================================
  Files           79       79              
  Lines         3992     3992              
===========================================
- Hits          1810     1807       -3     
- Misses        2013     2015       +2     
- Partials       169      170       +1     
Impacted Files Coverage Δ
cmd/ndm_daemonset/controller/ndmconfig.go 73.33% <ø> (ø)
cmd/ndm_daemonset/probe/addhandler.go 69.93% <0.00%> (-0.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niladrih niladrih merged commit b93fdc3 into openebs-archive:develop Feb 9, 2023
@niladrih niladrih deleted the deps branch February 9, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants