Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add graded and block_type to dim_course_blocks #48

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Feb 27, 2024

Description

This PR adds the fields graded and block_type to the dim_course_blocks model

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 27, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 requested a review from bmtcril February 27, 2024 20:45
@Ian2012 Ian2012 force-pushed the cag/extend-course-blocks branch 2 times, most recently from d0db5e2 to 0f09ba8 Compare February 28, 2024 15:35
@Ian2012 Ian2012 force-pushed the cag/fact-grade-status branch 17 times, most recently from 00a2bd7 to 91e226d Compare February 28, 2024 21:27
Copy link
Contributor

@SoryRawyer SoryRawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but can you add these fields to the documentation in schema.yml?

@Ian2012 Ian2012 force-pushed the cag/fact-grade-status branch 2 times, most recently from 6533db1 to 7026d9f Compare February 29, 2024 20:53
@Ian2012 Ian2012 changed the base branch from cag/fact-grade-status to main February 29, 2024 20:59
@Ian2012 Ian2012 requested a review from SoryRawyer March 4, 2024 12:42
models/base/schema.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@SoryRawyer SoryRawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have that one comment about the documentation. Otherwise, looks good!

@Ian2012 Ian2012 merged commit c569a22 into main Mar 5, 2024
3 checks passed
@Ian2012 Ian2012 deleted the cag/extend-course-blocks branch March 5, 2024 14:31
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants