Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH Request] Need review on upgrade requirements workflow PR #550

Closed
aht007 opened this issue Nov 24, 2022 · 4 comments
Closed

[GH Request] Need review on upgrade requirements workflow PR #550

aht007 opened this issue Nov 24, 2022 · 4 comments
Assignees
@arbrandes
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@aht007
Copy link
Member

aht007 commented Nov 24, 2022

Firm Name

2U

Urgency

High Urgency - Upgrade Jobs failing daily across 2U/OpenedX repos

Problem/Request

Problem
There is a bug in upgrade requirements workflow which is causing the upgrade jobs to fail daily. It was uncovered just recently because previously all the repos were using workflow from edX's github org. After the jobs were updated to use openedX's workflow the builds started to fail.

Request
I have fixed the bug in this PR: openedx/.github#33 but I don't have access to merge this.I need someone from your team to review and merge this.

Reasoning

N/A
@aht007 aht007 added the github-request Request for change to access level or settings in the openedx GitHub organization. label Nov 24, 2022
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/tcril-oncall will take a look as soon as they can.

@arbrandes arbrandes self-assigned this Nov 24, 2022
@arbrandes
Copy link
Contributor

Reviewed it, but I suspect the problem should be fixed in the calling workflow, not in the shared one.

@arbrandes arbrandes mentioned this issue Nov 24, 2022
Closed
36 tasks
@arbrandes
Copy link
Contributor

This is my recommended fix: openedx/.github#35

@aht007 aht007 changed the title [GH Request] New review on upgrade requirements workflow PR [GH Request] Need review on upgrade requirements workflow PR Nov 25, 2022
@arbrandes
Copy link
Contributor

Fix merged. @aht007, feel free to reopen this issue if your problem persists!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbrandes arbrandes

Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arbrandes @aht007