New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the Profile MFE #28
Comments
I don't think anyone at edX is actively looking at this list. I can be a contact to help get things merged here. |
As far as I understand, the profile MFE is not internationalized or localized at all, either in Lilac or the master branch: I would expect the profile page to be in French, given my browser and my Open edX account settings. If it is any comfort, the profile page on edX.org is not translated either: It should be noted that the Account MFE does not seem to be translated either on edX.org. However, the "Order History" (ecommerce) page is partially translated, so something right must be happening there: I can reproduce the problem, both locally and on edx.org, in French and in Spanish. It seems like we have an overarching problem with MFE translations. In my understanding, the projects are translated with the help of Transifex. For instance, here are the Spanish strings for the profile MFE: https://www.transifex.com/open-edx/edx-platform/viewstrings/#es_419/frontend-app-profile/186018400 As we can see, the profile MFE is fully translated. The translation strings were correctly collected in the frontend-app-profile repo: https://github.com/edx/frontend-app-profile/blob/master/src/i18n/messages/es_419.json However, I can't get these strings to be displayed in my locally running Profile MFE (or on edX.org). @davidjoy can you shed some light on this? |
Note that "Primary Language Spoken" is not the same as setting the site language, which is done in your account settings (either through the MFE or old experience) That said, I see that the FR translations are all in English right now, which means they probably haven't been accepted in Transifex. es_419, on the other hand, looks to be fully translated. If you set your site language in account settings and come back, I'd expect Spanish to be translated, but FR to appear English. |
Right! However, I still can't get the Profile MFE in Spanish, even when I set the platform language to es_419 and change the user site language, from the account. I'll keep investigating. |
We got i18n to work in the profile MFE, thanks to a tutor bugfix. We should also be able to override branding assets, thanks to a pending PR by @BbrSofiane. So this issue should be closed pretty soon. |
Coordinate, and if necessary execute, the tasks necessary to get the Profile MFE up to speed for Lilac:
The text was updated successfully, but these errors were encountered: