BB-749 Update robots.txt.j2 to accept Allow rule and multiple values #4942
BB-749 Update robots.txt.j2 to accept Allow rule and multiple values #4942
Conversation
Thanks for the pull request, @john2x! I've created OSPR-2977 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
@john2x Thank you for your contribution, please let me know once it is ready to be looked at. |
@natabene This is ready to be looked at, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this by running the playbook and verifying the generated robots.txt file for various values.
- I read through the code
-
I checked for accessibility issuesNA -
Includes documentationNA
@john2x, can you update this PR to resolve the merge conflict? |
@john2x Can you let me know once you resolve the merge conflict? |
3dcd1c1
to
a7eb846
Compare
@natabene @lgp171188 I've rebased to the latest change from |
@john2x Thanks! @edx/devops This is ready for your review, when you have time. |
@natabene do you have updates for the review/prioritization of this PR? |
@john2x Sorry, we have not had a chance to review it yet, I will ping team again. Do you know why checks are failing now? |
@natabene Thanks! The checks was because of conflicts on the |
@john2x Thank you! @edx/devops Can you give this a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@jdmulloy Can you merge, too? Open edX community contributors don't have the necessary permissions to merge. |
@john2x 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@natabene, can this be cherry-picked to Ironwood? |
I've cherry-picked this onto Ironwood. |
Configuration Pull Request
This PR updates the robots.txt.j2 template to satisfy the following:
Allow
rulesAgent
,Disallow
, andAllow
as a list of stringsTesting
To test the template, checkout this branch and add a test YAML file containing the
NGINX_ROBOT_RULES
values, and run ansible to render the template:This will render the template and save it to
test.txt
.Here are some sample values for
NGINX_ROBOT_RULES
and their expected output:Discussions: https://gitlab.com/opencraft/client/lumerical/configuration/merge_requests/5
Reviewers
Make sure that the following steps are done before merging: