Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

[Bug]: deprecated e2e repo still included in devstack by default. #1090

Closed
2 of 3 tasks
bradenmacdonald opened this issue Jun 8, 2023 · 1 comment
Closed
2 of 3 tasks
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@bradenmacdonald
Copy link

bradenmacdonald commented Jun 8, 2023

A/C

Describe the bug that you are seeing.

We got a bug report from the community that setting up a devstack using OPENEDX_RELEASE set to olive.master or olive.4 is not working for new installations of devstack:

# make dev.clone
The [ecommerce] repo is already checked out. Checking for updates.
Checking out branch open-release/olive.4
From https://github.com/openedx/ecommerce
 * tag                   open-release/olive.4 -> FETCH_HEAD
Already up to date.
Cloning into 'edx-e2e-tests'...
fatal: Remote branch open-release/olive.4 not found in upstream origin
make[1]: *** [Makefile:173: impl-dev.clone.ssh] Error 128
make[1]: Leaving directory '/home/zest/setup/programs/devstack-container/devstack'
Would you like to assist devstack development by sending anonymous usage metrics to edX? Run `make metrics-opt-in` to learn more!
make: *** [Makefile:176: dev.clone.ssh] Error 2

Since e2e tests have been deprecated it seems like this repo and related functionality should be removed from devstack?

Did this happen on the host (your machine or the remote instance) or in the container?

host

Steps to reproduce.

  1. Start with a fresh clone of devstack that has no repos or data.
  2. Run OPENEDX_RELEASE=olive.master make dev.clone

You will see:

Cloning into 'edx-e2e-tests'...
fatal: Remote branch open-release/olive.master not found in upstream origin

What system was this issue seen on?

Apple Silicon

@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Jun 8, 2023
timmc-edx added a commit that referenced this issue Jun 15, 2023
See #1090

Also update a frontend repo's URL to correct org.
@timmc-edx
Copy link
Contributor

I've fixed this on master and have another PR to backport it to Palm (#1102) but I wasn't able to backport it to Olive (#1103) -- or at least, not without tests breaking. It's possible that our provisioning CI checks just don't work very well on named release branches.

I'm probably not going to pursue the Olive fix since Palm is now current and I'm leery of checking in changes that might have broken something else, but if someone wants to push it forward, there's at least a branch to start from.

@timmc-edx timmc-edx self-assigned this Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants