Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use configured platform name in email reminder, not "edX" #319

Closed
2 tasks done
kdmccormick opened this issue Apr 17, 2024 · 4 comments
Closed
2 tasks done

Use configured platform name in email reminder, not "edX" #319

kdmccormick opened this issue Apr 17, 2024 · 4 comments
Assignees
@arbrandes @leangseu-edx
Labels
bug Report of or fix for something that isn't working as intended business-specific Code that relates to a specific user and should be refactored and removed.
Milestone
Redwood.1

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Apr 17, 2024 •
edited by arbrandes
Loading

This string should use the configured platform name instead of edX:

frontend-app-learner-dashboard/src/containers/LearnerDashboardHeader/ConfirmEmailBanner/messages.js

Line 12 in 272870f

defaultMessage: 'Remember to confirm your email so that you can keep learning on edX! {confirmNowButton}.',

image

PRs
Beta Give feedback
  1. fix: Remove edX-specific reference #359
  2. [Backport] fix: Remove edX-specific reference #360
@kdmccormick kdmccormick mentioned this issue Apr 17, 2024
Merged
@e0d
Copy link

e0d commented Apr 18, 2024

I noticed this too and this search will show all the instances that need to be updated.

https://github.com/search?q=org%3Aopenedx%20%22Remember%20to%20confirm%20your%20email%20so%20that%20you%20can%20keep%20learning%20on%20edX%22&type=code

@e0d
Copy link

e0d commented Apr 18, 2024

The configured platform name can be accessed via

getConfig().SITE_NAME

@kdmccormick kdmccormick added the business-specific Code that relates to a specific user and should be refactored and removed. label Apr 19, 2024
@arbrandes arbrandes self-assigned this May 2, 2024
@arbrandes arbrandes added this to the Redwood.1 milestone May 2, 2024
@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label May 9, 2024
@arbrandes
Copy link
Contributor

Fixed it by the simpler expedient of not invoking the platform name at all.

@kdmccormick
Copy link
Member Author

Thanks Adolfo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbrandes arbrandes

@leangseu-edx leangseu-edx

Labels
bug Report of or fix for something that isn't working as intended business-specific Code that relates to a specific user and should be refactored and removed.
Projects
Build-Test-Release Working Group
Status: Done
Frontend Working Group
Status: Closed
Milestone
Redwood.1
Development

No branches or pull requests
4 participants
@arbrandes @e0d @kdmccormick @leangseu-edx