feat: Improve code coverage 3 #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brobro10000
commented
Apr 18, 2024
| @@ -6,6 +6,36 @@ import { queryCanRedeem } from '../queries'; | |||
| import useEnterpriseCustomer from './useEnterpriseCustomer'; | |||
| import useLateRedemptionBufferDays from './useLateRedemptionBufferDays'; | |||
|
|
|||
| export function transformCourseRedemptionEligibility({ | |||
There was a problem hiding this comment.
Opted to abstract this logic outside of the hook into a separate function. Reason being is more efficient mocking in tests by passing in the mocked and fetched metadata with the expectation that the data we pass in prior to the transform should match the post transform output.
brobro10000
force-pushed
the
hu/ent-improve-code-cov-3
branch
4 times, most recently
from
fd9c80e
to
bafddf3
Compare
| jest.clearAllMocks(); | ||
| }); | ||
| it.each([ | ||
| /** |
There was a problem hiding this comment.
Helpful comments to parse these mock data cases :)
src/components/app/data/hooks/usePassLearnerCsodParams.test.jsx
Outdated
Show resolved
Hide resolved
brobro10000
force-pushed
the
hu/ent-improve-code-cov-3
branch
from
49a3004
to
25740a4
Compare
brobro10000
force-pushed
the
hu/ent-improve-code-cov-3
branch
3 times, most recently
from
d6bf0d9
to
29f59b4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1065 +/- ##
==========================================
- Coverage 84.87% 84.67% -0.20%
==========================================
Files 320 386 +66
Lines 6399 7947 +1548
Branches 1552 1921 +369
==========================================
+ Hits 5431 6729 +1298
- Misses 941 1160 +219
- Partials 27 58 +31 ☔ View full report in Codecov by Sentry. |
brobro10000
force-pushed
the
hu/ent-improve-code-cov-3
branch
from
29f59b4
to
2e47a01
Compare
adamstankiewicz
approved these changes
Apr 25, 2024
adamstankiewicz
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional tests to improve coverage:
useBrowseAndRequest
useCourseRedemptionEligibility
useEnterpriseCourseEnrollments
useIsAssignmnetOnlyLearner
useLateRedemptionBuffer
usePassLearenrCsodParam
Updates hooks in course/data to more accurately test the intended behavior of the hooks.
Final iteration of improve code cov of the following PRs,
#1060
#1055
For all changes
Only if submitting a visual change