Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide my career tab behind feature flag #1076

Merged
merged 1 commit into from
May 9, 2024

Conversation

jajjibhai008
Copy link
Contributor

Description

JIRA -> ENT-8774

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (f5b08c3) to head (87b939c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1076   +/-   ##
=======================================
  Coverage   84.79%   84.79%           
=======================================
  Files         393      393           
  Lines        8076     8076           
  Branches     1934     1934           
=======================================
  Hits         6848     6848           
  Misses       1171     1171           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 merged commit 989f6e1 into master May 9, 2024
7 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-8774 branch May 9, 2024 10:02
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[inform] Just a heads up, there is a prefetch of the learner skills API query used by the "My Career" tab, but it's not currently adhering to the FEATURE_ENABLE_MY_CAREER feature flag (source)

Do you think it's worth only doing the prefetch of the learner skills API query when FEATURE_ENABLE_MY_CAREER is enabled so users don't need to make an API request for data that won't be used (now that FEATURE_ENABLE_MY_CAREER is disabled for production)?

@@ -42,7 +42,7 @@ HOTJAR_DEBUG=''
ENABLE_SKILLS_QUIZ='true'
ENABLE_NOTICES=''
FEATURE_ENABLE_PROGRAMS='true'
FEATURE_ENABLE_MY_CAREER='true'
FEATURE_ENABLE_MY_CAREER='false'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[inform] 'false' still evaluates as truthy within the environment variables. e.g., features.FEATURE_ENABLE_MY_CAREER would still be enabled.

If this should be falsey, use an empty string ''.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants