Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exec ed no remaining applications failure message. ENT-7059 #709

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Apr 14, 2023

https://2u-internal.atlassian.net/browse/ENT-7059
Added new message for not enough applications (enrollments) remaining, updated existing balance messages to be consistent with message pattern.

Not enough remaining applications
image

Not enough balance
image

Not enough user balance
image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e58eabf) 81.33% compared to head (6eba89c) 81.33%.

❗ Current head 6eba89c differs from pull request most recent head 7932861. Consider uploading reports for the commit 7932861 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         288      288           
  Lines        5662     5662           
  Branches     1370     1370           
=======================================
  Hits         4605     4605           
  Misses       1033     1033           
  Partials       24       24           
Impacted Files Coverage Δ
...ecutive-education-2u/ExecutiveEducation2UError.jsx 71.42% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -15,8 +15,9 @@ const ExecutiveEducation2UError = ({ failureReason, httpReferrer }) => {
const createExecutiveEducationFailureMessage = (failureCode) => {
const failureCodeMessages = {
no_offer_available: 'No offer is available to cover this course.',
no_offer_with_enough_balance: 'Your organization doesn’t have sufficient balance to cover this course.',
no_offer_with_enough_user_balance: 'You don’t have sufficient balance to cover this course.',
no_offer_with_enough_balance: 'Your enrollment was not completed! Your organization does not have remaining credit. Please contact your administrator in regards to this limit.',
Copy link
Member

@adamstankiewicz adamstankiewicz Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Please contact your administrator..." messaging is now largely duplicative of the following text below:

<p className="mb-6">
  Please contact your edX administrator to resolve the error and gain access to this content.
</p>

That said, both of these messages are soon changing in Markhors' redesign of these error screens (here and here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I removed the last sentence in each of the messages.

Copy link
Contributor

@macdiesel macdiesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after the text changes

@iloveagent57 iloveagent57 merged commit c259fb8 into master Apr 17, 2023
@iloveagent57 iloveagent57 deleted the aed/new-error-string-ee branch April 17, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants