-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exec ed no remaining applications failure message. ENT-7059 #709
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 288 288
Lines 5662 5662
Branches 1370 1370
=======================================
Hits 4605 4605
Misses 1033 1033
Partials 24 24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -15,8 +15,9 @@ const ExecutiveEducation2UError = ({ failureReason, httpReferrer }) => { | |||
const createExecutiveEducationFailureMessage = (failureCode) => { | |||
const failureCodeMessages = { | |||
no_offer_available: 'No offer is available to cover this course.', | |||
no_offer_with_enough_balance: 'Your organization doesn’t have sufficient balance to cover this course.', | |||
no_offer_with_enough_user_balance: 'You don’t have sufficient balance to cover this course.', | |||
no_offer_with_enough_balance: 'Your enrollment was not completed! Your organization does not have remaining credit. Please contact your administrator in regards to this limit.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Please contact your administrator..." messaging is now largely duplicative of the following text below:
<p className="mb-6">
Please contact your edX administrator to resolve the error and gain access to this content.
</p>
That said, both of these messages are soon changing in Markhors' redesign of these error screens (here and here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I removed the last sentence in each of the messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 after the text changes
6eba89c
to
7932861
Compare
https://2u-internal.atlassian.net/browse/ENT-7059
Added new message for not enough applications (enrollments) remaining, updated existing balance messages to be consistent with message pattern.
Not enough remaining applications
![image](https://user-images.githubusercontent.com/2307986/232150808-a698f0f6-b113-4ada-a9b8-e5405cc3f590.png)
Not enough balance
![image](https://user-images.githubusercontent.com/2307986/232150942-6fe47f89-e3ac-4a5b-a8e9-4f2a63e1e13f.png)
Not enough user balance
![image](https://user-images.githubusercontent.com/2307986/232151084-ebbde57d-7af0-4229-b829-136517b1d61c.png)
For all changes
Only if submitting a visual change