Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disallowed generic PropTypes workarounds #81

Open
Tracked by #71
arbrandes opened this issue Oct 21, 2022 · 3 comments
Open
Tracked by #71

Remove disallowed generic PropTypes workarounds #81

arbrandes opened this issue Oct 21, 2022 · 3 comments
Labels
bug Report of or fix for something that isn't working as intended

Comments

@arbrandes
Copy link
Contributor

arbrandes commented Oct 21, 2022 •
edited

On the Course Import page we're forcing the use of generic object PropType via an ugly PropTypes.objectOf(PropTypes.object). See here:

https://github.com/openedx/frontend-app-library-authoring/blob/f62d0aa/src/library-authoring/course-import/CourseImportPage.jsx#L151

Remove that and alter the ongoingImport data structure accordingly so we can use a definite PropType.
@arbrandes arbrandes mentioned this issue Oct 21, 2022
Open
5 tasks
@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label Dec 9, 2022
@jristau1984
Copy link
Contributor

This has been brought into the 2U Library Authoring epic with this internal ticket: https://2u-internal.atlassian.net/browse/TNL-10592

@navinkarkera
Copy link
Contributor

@jristau1984 @arbrandes Is this issue still relevant?

@arbrandes
Copy link
Contributor Author

Yes, the hack is still there:

https://github.com/openedx/frontend-app-library-authoring/blob/f62d0aa/src/library-authoring/course-import/CourseImportPage.jsx#L151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Report of or fix for something that isn't working as intended
Projects
Frontend Working Group
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arbrandes @navinkarkera @jristau1984