feat: open response assesment detail (problem steps) UI #263

johnvente · 2023-10-09T14:17:45Z

Description

This PR allows us to see in detail each step of a open response, which means 'Training,' 'Peer,' 'Self,' 'Staff,' and can also see feedback received and feedback given

Further information

openedx/edx-ora2#1974

BEFORE	NOW

Responses list

Assesment list

Assesment feedback received

Assesment feedback given

Here's what you see in the video explained:

There is an ORA open response type "Staff Assessment Only."
The instructor opens the new experience of ORA that contains the submissions of that Open response.
The instructor can see the details and more information, such as email, full name, list of responses, and feedback in detail.

Why are we proposing these changes?

This improvement enables instructors to access detailed information for each Open Response, making it easier for them to review ORA responses and maintain better control over the feedback process.

How to test

Create an unit with an open response type "Staff Assessment Only."
Submit the response
Go to instructor tab
In the unit click in "View and grade responses"

Now you can see the UI implemented

NOTE: it depends on this PR: openedx/edx-platform#33632

openedx-webhooks · 2023-10-09T14:17:52Z

Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov · 2023-10-09T15:50:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9cfab58) to head (6736a65).
Report is 3 commits behind head on master.

❗ Current head 6736a65 differs from pull request most recent head f19f7c0

Please upload reports for the commit f19f7c0 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##            master      #263    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          109       138    +29     
  Lines         1079      1346   +267     
  Branches       160       227    +67     
==========================================
+ Hits          1079      1346   +267

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

e0d · 2023-10-20T16:27:23Z

@johnvente noting that there are some check failures and conflicts that need attention. Also, note that this is still marked draft and the title says not to review.

johnvente · 2023-12-26T21:38:55Z

src/containers/ListView/SubmissionsTable.jsx

+const problemSteps = {
+  problemStepsTraining: true,
+  problemStepsPeers: false,
+  problemStepsSelf: true,
+  problemStepsStaff: true,
+};


Yep, it does

Good! Thanks

mariajgrimaldi · 2023-11-16T21:12:09Z

src/containers/ListView/SubmissionsTable.jsx

  );

-  formatStatus = ({ value }) => (<StatusBadge status={value} />);
+  emailAddressCell = ({ value }) => (
+    <Hyperlink destination="#" showLaunchIcon={false}>


why is the destination "#"?

Because it's a link but won't redirect to any destination

Oh! Thank you

mariajgrimaldi · 2023-11-16T21:13:30Z

src/containers/ListView/messages.js

@@ -38,9 +38,14 @@ const messages = defineMessages({
  },
  learnerSubmissionDate: {
    id: 'ora-grading.ListView.tableHeaders.learnerSubmissionDate',
-    defaultMessage: 'Learner submission date',
+    defaultMessage: 'Submission date',


why are we changing Learner submission date for Submission date?

It was a request in the view by @juancamilom

So it got through product review. Thanks.

mariajgrimaldi · 2023-11-16T21:13:46Z

src/containers/ListView/messages.js

+  },
+  problemSteps: {
+    id: 'ora-grading.ListView.problemSteps',
+    defaultMessage: 'Problem Steps',


Suggested change

defaultMessage: 'Problem Steps',

defaultMessage: 'Problem steps',

These titles are columns in the table they should be in capitalize

Didn't know that. Thanks.

src/containers/ReviewProblemStepsModal/ReviewProblemStepsContent.jsx

mariajgrimaldi · 2023-11-16T21:40:57Z

src/containers/ReviewProblemStepsModal/components/ReviewProblemStepsContent/messages.js

+    defaultMessage: 'Error',
+    description: 'Error title when response list has failed',
+  },
+  responseListMessageError: {


why do we need multiple messages for the same error?

We do not need the same error message, I did not know which one to use here they should be different

Should we ask internally?

src/containers/ReviewProblemStepsModal/components/ReviewProblemStepsContent/utils.js

src/containers/ReviewProblemStepsModal/index.jsx

src/containers/ReviewProblemStepsModal/messages.js

mariajgrimaldi · 2023-11-16T21:45:49Z

src/data/redux/thunkActions/grading.js

+ * @param {boolean} showReview - show modal for the review
+ * @param {string} submissionUUIDParam - to set an expecifict submission ID to load


should we use this kind of documentation for the modules we're adding?

johnvente · 2023-12-26T21:38:55Z

src/containers/ListView/SubmissionsTable.jsx

+const problemSteps = {
+  problemStepsTraining: true,
+  problemStepsPeers: false,
+  problemStepsSelf: true,
+  problemStepsStaff: true,
+};


Yep, it does

arbrandes · 2024-03-20T19:20:49Z

Before I do a proper review, do we have a thumbs-up from Product, for this one?

johnvente · 2024-03-21T14:04:04Z

Hi @arbrandes this is the thumbs-up from Product: openedx/edx-ora2#1974
I will add it to the description as well

mphilbrick211 · 2024-05-01T21:06:38Z

Hi @arbrandes just checking in on this!

BryanttV · 2024-05-10T21:48:00Z

We have just updated the PR including the necessary changes to consume the API in edx-ora2. There is still a need to rebase with master, resolve conflicts, and correct the unit tests.

arbrandes · 2024-05-15T13:31:56Z

@BryanttV, mind tackling that rebase so I can test this on master?

…nents

… it for test

BryanttV · 2024-05-17T20:10:40Z

Hi @arbrandes, I already rebased with master, you can test now. I'm not sure why the tests are failing, but we will spend some time trying to fix it internally. Thanks!

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 9, 2023

johnvente changed the title ~~feat problem steps detail UI~~ feat: Open Response Assesment detail (problem steps) UI Oct 9, 2023

johnvente changed the title ~~feat: Open Response Assesment detail (problem steps) UI~~ feat: open response assesment detail (problem steps) UI Oct 9, 2023

johnvente force-pushed the jv/feat-problem-steps-detail-ui branch 2 times, most recently from 9f6f802 to 51c5394 Compare October 9, 2023 20:33

mariajgrimaldi suggested changes Nov 16, 2023

View reviewed changes

johnvente force-pushed the jv/feat-problem-steps-detail-ui branch 3 times, most recently from 948551e to 78b5a29 Compare December 26, 2023 21:21

johnvente commented Dec 26, 2023

View reviewed changes

johnvente marked this pull request as ready for review December 26, 2023 22:34

mariajgrimaldi mentioned this pull request Feb 13, 2024

feat: update initialize endpoint and create assessments/feedback endpoint in ORA Staff Grader openedx/edx-ora2#2101

Merged

5 tasks

BryanttV mentioned this pull request Feb 14, 2024

feat: update initialize endpoint and create assessments/feedback endpoint in ORA Staff Grader openedx/edx-platform#33632

Merged

mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024

BryanttV mentioned this pull request Feb 22, 2024

feat: open response assesment detail (problem steps) UI eduNEXT/frontend-app-ora-grading#5

Draft

mariajgrimaldi self-requested a review February 28, 2024 13:34

mphilbrick211 requested a review from arbrandes March 20, 2024 16:25

johnvente added 5 commits May 17, 2024 12:44

feat: grading details UI problem steps

0788611

fix: status badge for step problems

14851b5

refactor: format code

0a728e1

docs: update submissionuuid param type

4242939

fix: adding more test cases

e23dc31

johnvente and others added 18 commits May 17, 2024 12:44

fix: adding more test coverage

2d2f88b

feat: adding unit test for responses list and assessemnts table compo…

3852a24

…nents

fix: removing testid for rubric component

375a6e8

fix: unit testing for not covered test cases

87dd3ca

fix: remove unnecesary console

b374c4d

fix: adding not covered tests

5cd90d4

feat: integration backend

e43acc2

refactor: adding more unit tests for all

5c98341

test: full unit test for review problem estep content hook and change…

df3423d

… it for test

fix: addresing pr comments

949a9e8

fix: jest problems

35250c1

refactor: use individual endpoint to get assessments feedback

06c5635

chore: update dependencies and snapshots

c6f1933

test: replace edx/react-unit-test-utils for enzyme

527d69b

chore: replace idAssessment for assessmentId

24d6df0

test: update unit tests

7ff03ef

refactor: replace @edx/paragon with @openedx/paragon

4c16376

chore: remove mock of paragon

6e41dee

BryanttV force-pushed the jv/feat-problem-steps-detail-ui branch from f8af29c to 6e41dee Compare May 17, 2024 18:07

chore: update snapshots

f19f7c0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: open response assesment detail (problem steps) UI #263

feat: open response assesment detail (problem steps) UI #263

johnvente commented Oct 9, 2023 •

edited

openedx-webhooks commented Oct 9, 2023 •

edited

codecov bot commented Oct 9, 2023 •

edited

e0d commented Oct 20, 2023

johnvente Dec 26, 2023

mariajgrimaldi Feb 13, 2024

mariajgrimaldi Nov 16, 2023

johnvente Dec 26, 2023

mariajgrimaldi Feb 13, 2024

mariajgrimaldi Nov 16, 2023

johnvente Dec 26, 2023

mariajgrimaldi Feb 13, 2024

mariajgrimaldi Nov 16, 2023

johnvente Dec 26, 2023

mariajgrimaldi Feb 13, 2024

mariajgrimaldi Nov 16, 2023

johnvente Dec 26, 2023

mariajgrimaldi Feb 13, 2024 •

edited

mariajgrimaldi Nov 16, 2023

johnvente Dec 26, 2023

arbrandes commented Mar 20, 2024

johnvente commented Mar 21, 2024 •

edited

mphilbrick211 commented May 1, 2024

BryanttV commented May 10, 2024

arbrandes commented May 15, 2024

BryanttV commented May 17, 2024

	defaultMessage: 'Problem Steps',
	defaultMessage: 'Problem steps',

		* @param {boolean} showReview - show modal for the review
		* @param {string} submissionUUIDParam - to set an expecifict submission ID to load

feat: open response assesment detail (problem steps) UI #263

Are you sure you want to change the base?

feat: open response assesment detail (problem steps) UI #263

Conversation

johnvente commented Oct 9, 2023 • edited

Description

Further information

Responses list

Assesment list

Assesment feedback received

Assesment feedback given

Why are we proposing these changes?

How to test

openedx-webhooks commented Oct 9, 2023 • edited

codecov bot commented Oct 9, 2023 • edited

Codecov Report

e0d commented Oct 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mariajgrimaldi Feb 13, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arbrandes commented Mar 20, 2024

johnvente commented Mar 21, 2024 • edited

mphilbrick211 commented May 1, 2024

BryanttV commented May 10, 2024

arbrandes commented May 15, 2024

BryanttV commented May 17, 2024

johnvente commented Oct 9, 2023 •

edited

openedx-webhooks commented Oct 9, 2023 •

edited

codecov bot commented Oct 9, 2023 •

edited

mariajgrimaldi Feb 13, 2024 •

edited

johnvente commented Mar 21, 2024 •

edited