-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add header styles inclusion #321
base: master
Are you sure you want to change the base?
feat: Add header styles inclusion #321
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 1078 1078
Branches 159 159
=========================================
Hits 1078 1078 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense, but I wonder what the impact is, visually. I can find some header-specific CSS here, and I'm worried that bringing in the default styles will break them, somehow.
Can we get before-after screenshots?
Hi @Lunyachek! Just following up on this. |
Sorry... didn't mean to close! |
Header styles inclusion like it done in frontend-app-learning - https://github.com/openedx/frontend-app-learning/blob/master/src/index.scss#L7
It can be useful, for example, for the potential using of cookie banner